From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: David Edmondson <david.edmondson@oracle.com>, qemu-devel@nongnu.org
Cc: Eric Blake <eblake@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Juan Quintela <quintela@redhat.com>
Subject: Re: [RFC 1/2] migration: Introduce ram_transferred_add()
Date: Fri, 17 Dec 2021 20:09:12 +0100 [thread overview]
Message-ID: <1ecaa8aa-3b5c-ed91-3326-78376e4fe995@redhat.com> (raw)
In-Reply-To: <20211216123420.1328937-2-david.edmondson@oracle.com>
On 12/16/21 13:34, David Edmondson wrote:
> ...and use it.
>
> Signed-off-by: David Edmondson <david.edmondson@oracle.com>
> ---
> migration/ram.c | 23 ++++++++++++++---------
> migration/ram.h | 1 +
> 2 files changed, 15 insertions(+), 9 deletions(-)
> diff --git a/migration/ram.h b/migration/ram.h
> index c515396a9a..a5b2ffdc18 100644
> --- a/migration/ram.h
> +++ b/migration/ram.h
> @@ -51,6 +51,7 @@ int xbzrle_cache_resize(uint64_t new_size, Error **errp);
> uint64_t ram_bytes_remaining(void);
> uint64_t ram_bytes_total(void);
> void mig_throttle_counter_reset(void);
> +void ram_transferred_add(uint64_t bytes);
Why make the method public? It seems an internal operation. Do you
plan to use it elsewhere?
next prev parent reply other threads:[~2021-12-17 19:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 12:34 [RFC 0/2] migration: Tally pre-copy, downtime and post-copy bytes independently David Edmondson
2021-12-16 12:34 ` [RFC 1/2] migration: Introduce ram_transferred_add() David Edmondson
2021-12-17 19:09 ` Philippe Mathieu-Daudé [this message]
2021-12-20 8:01 ` David Edmondson
2021-12-16 12:34 ` [RFC 2/2] migration: Tally pre-copy, downtime and post-copy bytes independently David Edmondson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ecaa8aa-3b5c-ed91-3326-78376e4fe995@redhat.com \
--to=philmd@redhat.com \
--cc=armbru@redhat.com \
--cc=david.edmondson@oracle.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).