From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Richard Henderson <richard.henderson@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
qemu-devel@nongnu.org,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Andreas Krebbel" <krebbel@linux.ibm.com>
Subject: Re: [PATCH RFC 1/1] accel/tcg: Clear PAGE_WRITE before translation
Date: Thu, 05 Aug 2021 22:36:13 +0200 [thread overview]
Message-ID: <1ecd7127f9f768a35b48c45441cd461d842be467.camel@linux.ibm.com> (raw)
In-Reply-To: <04de9e20-555a-f785-3dea-add345d4e64d@linaro.org>
On Thu, 2021-08-05 at 06:59 -1000, Richard Henderson wrote:
> On 8/5/21 12:56 AM, Ilya Leoshkevich wrote:
> > On Wed, 2021-08-04 at 14:30 -1000, Richard Henderson wrote:
> > > I think that the translator_ld*_swap functions should be moved
> > > out of
> > > include/exec/translator.h into accel/tcg/translator.c.
> >
> > Do we really need this? In the end, the added code is not that
> > large.
>
> I suppose it's not required, but they're already larger than they
> need to be.
>
> In my opinion, if you're going to swap one out-of-line function call
> for two out-of-line
> function calls (cpu_ld*_code + plugin_insn_append), you've probably
> made a bad size trade-off.
>
> With your added code, it'll be 3 out-of-line calls.
>
>
> r~
Fair enough. Let me send a v3 then.
Best regards,
Ilya
prev parent reply other threads:[~2021-08-05 20:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 22:46 [PATCH RFC 0/1] accel/tcg: Clear PAGE_WRITE before translation Ilya Leoshkevich
2021-08-04 22:46 ` [PATCH RFC 1/1] " Ilya Leoshkevich
2021-08-05 0:30 ` Richard Henderson
2021-08-05 10:56 ` Ilya Leoshkevich
2021-08-05 16:59 ` Richard Henderson
2021-08-05 20:36 ` Ilya Leoshkevich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ecd7127f9f768a35b48c45441cd461d842be467.camel@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=alex.bennee@linaro.org \
--cc=borntraeger@de.ibm.com \
--cc=dgilbert@redhat.com \
--cc=krebbel@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).