From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9962EC433E0 for ; Mon, 25 Jan 2021 15:15:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 09503230FC for ; Mon, 25 Jan 2021 15:15:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 09503230FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57724 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l43aA-0004A5-UE for qemu-devel@archiver.kernel.org; Mon, 25 Jan 2021 10:15:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48404) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l43XS-0002Oj-CG for qemu-devel@nongnu.org; Mon, 25 Jan 2021 10:12:22 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:35199) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l43XQ-0006nU-FD for qemu-devel@nongnu.org; Mon, 25 Jan 2021 10:12:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611587539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8TEkt3UDBgb1mNARyF8ivldRPdPQbrGVG1ZoXi0Tw5U=; b=IYjurKhpH6Enc2ozYyD2RWYDcc4UnwMIwzRlYLn+dNIVYPZj+iL8g87aGEbqbjPgd8YSZy cHyY1pTgWyG51+CN0PZ13lHANcZ+x6U+LdAAHpCNYiFf6UM8t7ARqSygG457pNT7nfE20Z G90bBGItm4WV0WBUoKpbpSwQa8SYGmQ= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-295-PkwDBc6YNUSa7En7i3bw2w-1; Mon, 25 Jan 2021 10:12:16 -0500 X-MC-Unique: PkwDBc6YNUSa7En7i3bw2w-1 Received: by mail-ej1-f69.google.com with SMTP id by20so3904068ejc.1 for ; Mon, 25 Jan 2021 07:12:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8TEkt3UDBgb1mNARyF8ivldRPdPQbrGVG1ZoXi0Tw5U=; b=p1MQ+4cJowNsv8M8XIFWQ7btvKnsdTaRrMCLmyoVhxVfiywGIjVhGU1Az3c1wFth/2 P1851H0mzrnh/aqYDBwzuc2sljw5es5AZtZsJqP6+nMwtX1mYngf/vWES23sG5ZBZ4WU LcWQ5m8C653YqsopAjoy3FMwC47JuLf68l+6GSTnu4SO4y8TP0YiX0ePBZxq9ICe4uON olSGsmVu0sdKSNr2Eh8YN5waRhflMm+g83gCkzh0xTd/2vMxqrNxGXSZjGFZ11DBv4gw ensCkvpljem/4kfZSFqHwz8h7ZFGePZJtGFL1WxGDkAAVGF8hYLnM2q6LQfGYaEZ+Syh 2zmg== X-Gm-Message-State: AOAM5319amiXYkdzrJt9vDbJAsBAAsD75+DyF4xKbHWfH09lkVOR5bi1 XTNdb2RuWCwHASw86dx9bRccc/xNJDvCdeWWAnWZUmJgh9715qXYMl62Tc0fAj5vqHqKCLmIg4m LbRthFOW1LRHdZA8= X-Received: by 2002:a17:907:1629:: with SMTP id hb41mr632404ejc.197.1611587534895; Mon, 25 Jan 2021 07:12:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJwl11s6B+CdfOYZnRDwr6qn62AIT8CSDxDdjed2Cg5BK7lOlX1jhy5Qc3Vsu3/qYo6IagFurg== X-Received: by 2002:a17:907:1629:: with SMTP id hb41mr632387ejc.197.1611587534681; Mon, 25 Jan 2021 07:12:14 -0800 (PST) Received: from [192.168.1.36] (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id a11sm10660926edt.26.2021.01.25.07.12.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Jan 2021 07:12:14 -0800 (PST) Subject: Re: [PATCH v2 08/12] meson: Restrict emulation code From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= To: qemu-devel@nongnu.org, Paolo Bonzini References: <20210122204441.2145197-1-philmd@redhat.com> <20210122204441.2145197-9-philmd@redhat.com> <188f9142-d90f-ffda-3bff-3dafbb8d886c@redhat.com> Message-ID: <1ee452f5-f9cf-2efe-90b7-f05440d0d886@redhat.com> Date: Mon, 25 Jan 2021 16:12:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <188f9142-d90f-ffda-3bff-3dafbb8d886c@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.255, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Eduardo Habkost , Michael Roth , Richard Henderson , Markus Armbruster , Claudio Fontana Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 1/25/21 4:09 PM, Philippe Mathieu-Daudé wrote: > On 1/22/21 9:44 PM, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> Cc: Richard Henderson >> --- >> meson.build | 12 +++++++----- >> 1 file changed, 7 insertions(+), 5 deletions(-) >> >> diff --git a/meson.build b/meson.build >> index 396ea3aa19b..b5afa2923b3 100644 >> --- a/meson.build >> +++ b/meson.build >> @@ -1809,16 +1809,18 @@ >> qemuutil = declare_dependency(link_with: libqemuutil, >> sources: genh + version_res) >> >> -decodetree = generator(find_program('scripts/decodetree.py'), >> - output: 'decode-@BASENAME@.c.inc', >> - arguments: ['@INPUT@', '@EXTRA_ARGS@', '-o', '@OUTPUT@']) >> +if have_system or have_user > > Maybe better as: > > if not get_option('tcg').disabled() > > And even clearer as: > > if get_option('tcg').enabled() > > assuming enabled would be "auto" or "yes". ^ this comment is only for the decodetree generator, not for the target/ directory ;) > >> + decodetree = generator(find_program('scripts/decodetree.py'), >> + output: 'decode-@BASENAME@.c.inc', >> + arguments: ['@INPUT@', '@EXTRA_ARGS@', '-o', '@OUTPUT@']) >> + subdir('libdecnumber') >> + subdir('target') >> +endif >> >> subdir('audio') >> subdir('io') >> subdir('chardev') >> subdir('fsdev') >> -subdir('libdecnumber') >> -subdir('target') >> subdir('dump') >> >> block_ss.add(files( >> >