Re: [Qemu-devel] [PATCH v1 5/8] net: Remove the deprecated way of dumping network packets

[Eric Blake <eblake@redhat.com>]

On 02/19/2018 03:15 AM, Thomas Huth wrote:
> "-net dump" has been marked as deprecated since QEMU v2.10, since it
> only works with the deprecated 'vlan' parameter. Network dumping should
> be done with "-object filter-dump" nowadays instead. Since nobody
> complained so far about the deprecation message, let's finally get rid
> of "-net dump" now.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   net/dump.c      | 102 ++------------------------------------------------------
>   net/net.c       |   9 +----
>   qapi/net.json   |  27 +++------------
>   qemu-doc.texi   |   6 ----
>   qemu-options.hx |   8 -----
>   5 files changed, 7 insertions(+), 145 deletions(-)
> 

> +++ b/qapi/net.json
> @@ -39,8 +39,8 @@
>   #
>   # Add a network backend.
>   #
> -# @type: the type of network backend.  Current valid values are 'user', 'tap',
> -#        'vde', 'socket', 'dump' and 'bridge'
> +# @type: the type of network backend.  Current valid values are for example
> +#        'user', 'tap', 'vde', 'socket', 'hubport' and 'bridge'
>   #

Look at qapi/block-core.json:BlockDeviceInfo::drv for precedence on how 
we've documented removal of options that used to work; you may want to 
copy that in the documentation here if it will help future readers 
figure out why their command no longer works.  But I'm not seeing 
anything wrong from the UI perspective given that we have had a 
deprecation period, so

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org