qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH] accel/tcg: Introduce and use MO_ALIGN_TLB_ONLY
Date: Sat, 1 Nov 2025 10:43:44 +0100	[thread overview]
Message-ID: <1f05a80a-12ba-46b8-9681-43e9331221dc@linaro.org> (raw)
In-Reply-To: <82f3c305-bbc4-480a-9c73-ef4386e4ab3b@tls.msk.ru>

On 10/31/25 21:21, Michael Tokarev wrote:
>> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
>> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3171
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> 
> I wonder if we should pick this up for qemu-stable too (including
> 10.0.x lts series).  It's a rather large change though.
> 
> The patch applies cleanly to both 10.0.x and 10.1.x series, and
> seems to be working fine.  Maybe it can be picked up for a later
> release.

I think you should hold off for now.

> What's the implication of this bug, anyway?

Failure to raise an alignment trap accessing Device memory when architecturally required 
with -smp 1.

Before 10.0, we had no support for raising alignment traps accessing Device memory under 
any conditions, so this is more filling a hole in the implementation than a fixing a 
regression.


r~


  reply	other threads:[~2025-11-01  9:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-22  0:17 [PATCH] accel/tcg: Introduce and use MO_ALIGN_TLB_ONLY Richard Henderson
2025-10-29  8:23 ` Richard Henderson
2025-10-29  9:00 ` Manos Pitsidianakis
2025-10-29 13:32 ` Philippe Mathieu-Daudé
2025-10-31 20:21 ` Michael Tokarev
2025-11-01  9:43   ` Richard Henderson [this message]
2025-11-01  9:49     ` Michael Tokarev
2025-11-01 10:53     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1f05a80a-12ba-46b8-9681-43e9331221dc@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=mjt@tls.msk.ru \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).