qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
	richard.henderson@linaro.org, clegoate@redhat.com,
	hsp.cat7@gmail.com, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/2] accel/tcg: add assert() check in tb_invalidate_phys_page_range__locked()
Date: Thu, 29 Jun 2023 11:08:09 +0200	[thread overview]
Message-ID: <1f0f8b0a-1f38-29f5-5363-13a88af2ba91@linaro.org> (raw)
In-Reply-To: <20230629082522.606219-3-mark.cave-ayland@ilande.co.uk>

On 29/6/23 10:25, Mark Cave-Ayland wrote:
> Add an assert() check in tb_invalidate_phys_page_range__locked() to ensure that
> both the start and last addresses are within the same target page. Note that
> due to performance concerns the check is only enabled when QEMU is configured
> with --enable-debug-tcg.
> 
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
>   accel/tcg/tb-maint.c | 4 ++++
>   1 file changed, 4 insertions(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



  reply	other threads:[~2023-06-29  9:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-29  8:25 [PATCH 0/2] accel/tcg: fix page invalidation in tb_invalidate_phys_range() Mark Cave-Ayland
2023-06-29  8:25 ` [PATCH 1/2] accel/tcg: fix start page passed to tb_invalidate_phys_page_range__locked() Mark Cave-Ayland
2023-06-29  9:08   ` Cédric Le Goater
2023-06-29  8:25 ` [PATCH 2/2] accel/tcg: add assert() check in tb_invalidate_phys_page_range__locked() Mark Cave-Ayland
2023-06-29  9:08   ` Philippe Mathieu-Daudé [this message]
2023-06-30  8:05   ` Michael Tokarev
2023-06-30 11:25     ` BALATON Zoltan
2023-06-30 13:34 ` [PATCH 0/2] accel/tcg: fix page invalidation in tb_invalidate_phys_range() Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1f0f8b0a-1f38-29f5-5363-13a88af2ba91@linaro.org \
    --to=philmd@linaro.org \
    --cc=clegoate@redhat.com \
    --cc=hsp.cat7@gmail.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).