From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Markus Armbruster" <armbru@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 03/15] char-pty: Drop "char device redirected to" message
Date: Tue, 9 Apr 2019 12:40:03 +0200 [thread overview]
Message-ID: <1f1ab942-49e9-0714-c6bc-65c7a0c4fa27@redhat.com> (raw)
In-Reply-To: <87bm1gr83k.fsf@dusky.pond.sub.org>
On 4/8/19 2:31 PM, Markus Armbruster wrote:
> Marc-André Lureau <marcandre.lureau@redhat.com> writes:
>
>> Hi
>>
>> On Mon, Apr 8, 2019 at 10:36 AM Markus Armbruster <armbru@redhat.com> wrote:
>>>
>>> char_pty_open() prints a "char device redirected to PTY_NAME (label
>>> LABEL)" message to the current monitor or else to stderr. No other
>>> ChardevClass::open() prints anything on success. Drop the message.
>>>
>>> Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
>>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>>> ---
>>> chardev/char-pty.c | 2 --
>>> 1 file changed, 2 deletions(-)
>>>
>>
>> I guess that was printed for convenience.
>>
>> Allocated pty can be read from "info chardev", so I suppose we can
>> make qemu more silent. Fine with me:
>>
>> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Thanks!
>
> If we should decide the message is still useful enough to be worth
> keeping, I could direct it to stdout instead of dropping it.
I prefer this, if Marc-André is still OK.
next prev parent reply other threads:[~2019-04-09 10:40 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 8:36 [Qemu-devel] [PATCH 00/15] Clean up use of error_printf() Markus Armbruster
2019-04-08 8:36 ` Markus Armbruster
2019-04-08 8:36 ` [Qemu-devel] [PATCH 01/15] qemu-img: Use error_vreport() in error_exit() Markus Armbruster
2019-04-08 8:36 ` Markus Armbruster
2019-04-08 18:37 ` Eric Blake
2019-04-08 18:37 ` Eric Blake
2019-04-08 8:36 ` [Qemu-devel] [PATCH 02/15] block/ssh: Do not report read/write/flush errors to the user Markus Armbruster
2019-04-08 8:36 ` Markus Armbruster
2019-04-08 17:22 ` [Qemu-devel] Whither qemu's ssh driver? (was: Re: [PATCH 02/15] block/ssh: Do not report read/write/flush errors to the user) Richard W.M. Jones
2019-04-08 17:22 ` Richard W.M. Jones
2019-04-08 18:07 ` [Qemu-devel] Whither qemu's ssh driver? Markus Armbruster
2019-04-08 18:07 ` Markus Armbruster
2019-04-08 18:13 ` Richard W.M. Jones
2019-04-08 18:13 ` Richard W.M. Jones
2019-04-08 18:33 ` [Qemu-devel] Whither qemu's ssh driver? (was: Re: [PATCH 02/15] block/ssh: Do not report read/write/flush errors to the user) Max Reitz
2019-04-08 18:33 ` Max Reitz
2019-04-09 6:05 ` [Qemu-devel] Whither qemu's ssh driver? Markus Armbruster
2019-04-09 6:05 ` Markus Armbruster
2019-04-08 19:13 ` [Qemu-devel] [PATCH 02/15] block/ssh: Do not report read/write/flush errors to the user Eric Blake
2019-04-08 19:13 ` Eric Blake
2019-04-09 6:09 ` Markus Armbruster
2019-04-09 6:09 ` Markus Armbruster
2019-04-08 8:36 ` [Qemu-devel] [PATCH 03/15] char-pty: Drop "char device redirected to" message Markus Armbruster
2019-04-08 8:36 ` Markus Armbruster
2019-04-08 9:20 ` Marc-André Lureau
2019-04-08 9:20 ` Marc-André Lureau
2019-04-08 12:31 ` Markus Armbruster
2019-04-08 12:31 ` Markus Armbruster
2019-04-09 10:40 ` Philippe Mathieu-Daudé [this message]
2019-04-09 10:40 ` Philippe Mathieu-Daudé
2019-04-09 11:25 ` Marc-André Lureau
2019-04-09 11:25 ` Marc-André Lureau
2019-04-11 11:47 ` Daniel P. Berrangé
2019-04-11 11:47 ` Daniel P. Berrangé
2019-04-08 8:36 ` [Qemu-devel] [PATCH 04/15] loader-fit: Wean off error_printf() Markus Armbruster
2019-04-08 8:36 ` Markus Armbruster
2019-04-08 10:49 ` Philippe Mathieu-Daudé
2019-04-08 10:49 ` Philippe Mathieu-Daudé
2019-04-08 8:36 ` [Qemu-devel] [PATCH 05/15] mips/boston: Report errors with error_report(), not error_printf() Markus Armbruster
2019-04-08 8:36 ` Markus Armbruster
2019-04-08 10:53 ` Philippe Mathieu-Daudé
2019-04-08 10:53 ` Philippe Mathieu-Daudé
2019-04-08 8:36 ` [Qemu-devel] [PATCH 06/15] pci: Report fatal " Markus Armbruster
2019-04-08 8:36 ` Markus Armbruster
2019-04-08 8:41 ` Marcel Apfelbaum
2019-04-08 8:41 ` Marcel Apfelbaum
2019-04-08 8:36 ` [Qemu-devel] [PATCH 07/15] hpet: Report warnings with warn_report(), " Markus Armbruster
2019-04-08 8:36 ` Markus Armbruster
2019-04-08 8:36 ` [Qemu-devel] [PATCH 08/15] vfio: " Markus Armbruster
2019-04-08 8:36 ` Markus Armbruster
2019-04-08 8:36 ` [Qemu-devel] [PATCH 09/15] s390x/kvm: " Markus Armbruster
2019-04-08 8:36 ` Markus Armbruster
2019-04-08 8:39 ` Thomas Huth
2019-04-08 8:39 ` Thomas Huth
2019-04-08 9:04 ` Cornelia Huck
2019-04-08 9:04 ` Cornelia Huck
2019-04-08 12:32 ` Markus Armbruster
2019-04-08 12:32 ` Markus Armbruster
2019-04-08 8:36 ` [Qemu-devel] [PATCH 10/15] vl: Make -machine $TYPE, help and -accel help print to stdout Markus Armbruster
2019-04-08 8:36 ` Markus Armbruster
2019-04-08 8:44 ` Marcel Apfelbaum
2019-04-08 8:44 ` Marcel Apfelbaum
2019-04-08 12:33 ` Markus Armbruster
2019-04-08 12:33 ` Markus Armbruster
2019-04-08 8:36 ` [Qemu-devel] [PATCH 11/15] monitor error: Make printf()-like functions return a value Markus Armbruster
2019-04-08 8:36 ` Markus Armbruster
2019-04-08 13:18 ` Markus Armbruster
2019-04-08 13:18 ` Markus Armbruster
2019-04-08 16:23 ` Dr. David Alan Gilbert
2019-04-08 16:23 ` Dr. David Alan Gilbert
2019-04-08 8:36 ` [Qemu-devel] [PATCH 12/15] qemu-print: New qemu_printf(), qemu_vprintf() etc Markus Armbruster
2019-04-08 8:36 ` Markus Armbruster
2019-04-08 11:00 ` Philippe Mathieu-Daudé
2019-04-08 11:00 ` Philippe Mathieu-Daudé
2019-04-09 18:00 ` Dr. David Alan Gilbert
2019-04-09 18:00 ` Dr. David Alan Gilbert
2019-04-10 5:08 ` Markus Armbruster
2019-04-10 5:08 ` Markus Armbruster
2019-04-08 8:36 ` [Qemu-devel] [PATCH 13/15] blockdev: Make -drive format=help print to stdout Markus Armbruster
2019-04-08 8:36 ` Markus Armbruster
2019-04-08 11:01 ` Philippe Mathieu-Daudé
2019-04-08 11:01 ` Philippe Mathieu-Daudé
2019-04-08 8:36 ` [Qemu-devel] [PATCH 14/15] char: Make -chardev help " Markus Armbruster
2019-04-08 8:36 ` Markus Armbruster
2019-04-08 9:10 ` Marc-André Lureau
2019-04-08 9:10 ` Marc-André Lureau
2019-04-08 11:02 ` Philippe Mathieu-Daudé
2019-04-08 11:02 ` Philippe Mathieu-Daudé
2019-04-08 19:04 ` Eric Blake
2019-04-08 19:04 ` Eric Blake
2019-04-09 6:10 ` Markus Armbruster
2019-04-09 6:10 ` Markus Armbruster
2019-04-08 8:36 ` [Qemu-devel] [PATCH 15/15] monitor: Simplify how -device/device_add print help Markus Armbruster
2019-04-08 8:36 ` Markus Armbruster
2019-04-09 18:41 ` Dr. David Alan Gilbert
2019-04-09 18:41 ` Dr. David Alan Gilbert
2019-04-08 10:51 ` [Qemu-devel] [PATCH 00/15] Clean up use of error_printf() no-reply
2019-04-08 10:51 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f1ab942-49e9-0714-c6bc-65c7a0c4fa27@redhat.com \
--to=philmd@redhat.com \
--cc=armbru@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).