From: Paolo Bonzini <pbonzini@redhat.com>
To: Bruce Rogers <brogers@suse.com>, qemu-devel@nongnu.org
Cc: berrange@redhat.com, kraxel@redhat.com
Subject: Re: [PATCH] meson: Only install icons and qemu.desktop if have_system
Date: Fri, 16 Oct 2020 09:35:51 +0200 [thread overview]
Message-ID: <1f1fa79a-3e58-2061-661e-5198d60430bc@redhat.com> (raw)
In-Reply-To: <20201015201840.282956-1-brogers@suse.com>
On 15/10/20 22:18, Bruce Rogers wrote:
> These files are not needed for a linux-user only install.
>
> Signed-off-by: Bruce Rogers <brogers@suse.com>
> ---
> ui/meson.build | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/ui/meson.build b/ui/meson.build
> index 78ad792ffb..fb36d305ca 100644
> --- a/ui/meson.build
> +++ b/ui/meson.build
> @@ -113,8 +113,11 @@ if have_system or xkbcommon.found()
> endif
>
> subdir('shader')
> -subdir('icons')
>
> -install_data('qemu.desktop', install_dir: config_host['qemu_desktopdir'])
> +if have_system
> + subdir('icons')
> +
> + install_data('qemu.desktop', install_dir: config_host['qemu_desktopdir'])
> +endif
>
> modules += {'ui': ui_modules}
>
Queued, thanks.
Paolo
next prev parent reply other threads:[~2020-10-16 7:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 20:18 [PATCH] meson: Only install icons and qemu.desktop if have_system Bruce Rogers
2020-10-16 7:35 ` Paolo Bonzini [this message]
2020-10-16 8:26 ` Philippe Mathieu-Daudé
2020-10-19 8:11 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f1fa79a-3e58-2061-661e-5198d60430bc@redhat.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=brogers@suse.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).