From: Richard Henderson <richard.henderson@linaro.org>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Fam Zheng <fam@euphon.net>
Cc: pbonzini@redhat.com, laurent@vivier.eu, qemu-block@nongnu.org,
qemu-devel@nongnu.org
Subject: Re: [PATCH 3/6] scsi-disk: add MODE_PAGE_APPLE quirk for Macintosh
Date: Thu, 21 Apr 2022 11:11:22 -0700 [thread overview]
Message-ID: <1f26c28f-dd80-cadb-d308-56c9a91bea2f@linaro.org> (raw)
In-Reply-To: <e6d29d64-fe3b-8d4b-3985-146c11bfd537@ilande.co.uk>
On 4/21/22 08:29, Mark Cave-Ayland wrote:
>> You need (1 << SCSI_DISK_QUIRK_MODE_PAGE_APPLE) instead.
>
> Doh, you're absolutely right. I believe the current recommendation is to use the BIT()
> macro in these cases.
We probably need to fix BIT() to use 1ULL.
At present it's using 1UL, to match the other (unfortunate) uses of unsigned long within
bitops.h. The use of BIT() for things unrelated to bitops.h just bit a recent risc-v pull
request, in that it failed to build on all 32-bit hosts.
r~
next prev parent reply other threads:[~2022-04-21 18:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 6:51 [PATCH 0/6] scsi: add support for FORMAT UNIT command and quirks Mark Cave-Ayland
2022-04-21 6:51 ` [PATCH 1/6] scsi-disk: add FORMAT UNIT command Mark Cave-Ayland
2022-05-30 14:23 ` Philippe Mathieu-Daudé via
2022-04-21 6:51 ` [PATCH 2/6] scsi-disk: add new quirks bitmap to SCSIDiskState Mark Cave-Ayland
2022-04-21 6:51 ` [PATCH 3/6] scsi-disk: add MODE_PAGE_APPLE quirk for Macintosh Mark Cave-Ayland
2022-04-21 13:27 ` Fam Zheng
2022-04-21 15:29 ` Mark Cave-Ayland
2022-04-21 18:11 ` Richard Henderson [this message]
2022-04-21 22:00 ` BALATON Zoltan
2022-04-24 14:50 ` Mark Cave-Ayland
2022-04-21 6:51 ` [PATCH 4/6] q800: implement compat_props to enable quirk_mode_page_apple for scsi-hd devices Mark Cave-Ayland
2022-04-21 6:51 ` [PATCH 5/6] q800: add default vendor, product and version information " Mark Cave-Ayland
2022-04-21 6:51 ` [PATCH 6/6] q800: add default vendor, product and version information for scsi-cd devices Mark Cave-Ayland
2022-04-24 14:54 ` [PATCH 0/6] scsi: add support for FORMAT UNIT command and quirks Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f26c28f-dd80-cadb-d308-56c9a91bea2f@linaro.org \
--to=richard.henderson@linaro.org \
--cc=fam@euphon.net \
--cc=laurent@vivier.eu \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).