From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB4F2C5DF61 for ; Thu, 7 Nov 2019 06:26:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B5B0521D6C for ; Thu, 7 Nov 2019 06:26:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5B0521D6C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39244 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSbF3-0003HW-QQ for qemu-devel@archiver.kernel.org; Thu, 07 Nov 2019 01:26:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36366) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSbE5-0002km-99 for qemu-devel@nongnu.org; Thu, 07 Nov 2019 01:25:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSbE3-00022h-Ir for qemu-devel@nongnu.org; Thu, 07 Nov 2019 01:25:00 -0500 Received: from mga07.intel.com ([134.134.136.100]:28420) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iSbE3-00020u-AT for qemu-devel@nongnu.org; Thu, 07 Nov 2019 01:24:59 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2019 22:24:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,277,1569308400"; d="scan'208";a="206062710" Received: from txu2-mobl.ccr.corp.intel.com (HELO [10.239.196.161]) ([10.239.196.161]) by orsmga006.jf.intel.com with ESMTP; 06 Nov 2019 22:24:53 -0800 Subject: Re: [PATCH v14 03/11] tests: Add test for QAPI builtin type time To: Eduardo Habkost References: <20191028075220.25673-1-tao3.xu@intel.com> <20191028075220.25673-4-tao3.xu@intel.com> <20191106205359.GR3812@habkost.net> From: Tao Xu Message-ID: <1f2fa942-0993-548b-1f5c-8345d564bf29@intel.com> Date: Thu, 7 Nov 2019 14:24:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191106205359.GR3812@habkost.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.100 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "lvivier@redhat.com" , "thuth@redhat.com" , "mst@redhat.com" , "qemu-devel@nongnu.org" , "Liu, Jingqi" , "Du, Fan" , "mdroth@linux.vnet.ibm.com" , "armbru@redhat.com" , "jonathan.cameron@huawei.com" , "imammedo@redhat.com" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/7/2019 4:53 AM, Eduardo Habkost wrote: > On Mon, Oct 28, 2019 at 03:52:12PM +0800, Tao Xu wrote: >> Add tests for time input such as zero, around limit of precision, >> signed upper limit, actual upper limit, beyond limits, time suffixes, >> and etc. >> >> Signed-off-by: Tao Xu >> --- > [...] >> + /* Close to signed upper limit 0x7ffffffffffffc00 (53 msbs set) */ >> + qdict = keyval_parse("time1=9223372036854774784," /* 7ffffffffffffc00 */ >> + "time2=9223372036854775295", /* 7ffffffffffffdff */ >> + NULL, &error_abort); >> + v = qobject_input_visitor_new_keyval(QOBJECT(qdict)); >> + qobject_unref(qdict); >> + visit_start_struct(v, NULL, NULL, 0, &error_abort); >> + visit_type_time(v, "time1", &time, &error_abort); >> + g_assert_cmphex(time, ==, 0x7ffffffffffffc00); >> + visit_type_time(v, "time2", &time, &error_abort); >> + g_assert_cmphex(time, ==, 0x7ffffffffffffc00); > > I'm confused by this test case and the one below[1]. Are these > known bugs? Shouldn't we document them as known bugs? Because do_strtosz() or do_strtomul() actually parse with strtod(), so the precision is 53 bits, so in these cases, 7ffffffffffffdff and fffffffffffffbff are rounded. > >> + visit_check_struct(v, &error_abort); >> + visit_end_struct(v, NULL); >> + visit_free(v); >> + >> + /* Close to actual upper limit 0xfffffffffffff800 (53 msbs set) */ >> + qdict = keyval_parse("time1=18446744073709549568," /* fffffffffffff800 */ >> + "time2=18446744073709550591", /* fffffffffffffbff */ >> + NULL, &error_abort); >> + v = qobject_input_visitor_new_keyval(QOBJECT(qdict)); >> + qobject_unref(qdict); >> + visit_start_struct(v, NULL, NULL, 0, &error_abort); >> + visit_type_time(v, "time1", &time, &error_abort); >> + g_assert_cmphex(time, ==, 0xfffffffffffff800); >> + visit_type_time(v, "time2", &time, &error_abort); >> + g_assert_cmphex(time, ==, 0xfffffffffffff800); > > [1] > >> + visit_check_struct(v, &error_abort); >> + visit_end_struct(v, NULL); >> + visit_free(v); > [...] >