qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH for-5.0] qcow2: Add incompatibility note between backing files and raw external data files
Date: Mon, 13 Apr 2020 13:11:16 -0500	[thread overview]
Message-ID: <1f31551c-2ac1-ac5b-01c4-005cca2cb2af@redhat.com> (raw)
In-Reply-To: <20200410121816.8334-1-berto@igalia.com>

On 4/10/20 7:18 AM, Alberto Garcia wrote:
> Backing files and raw external data files are mutually exclusive.
> The documentation of the raw external data bit (in autoclear_features)
> already indicates that, but we should also mention it on the other
> side.
> 
> Suggested-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
>   docs/interop/qcow2.txt | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/docs/interop/qcow2.txt b/docs/interop/qcow2.txt
> index 640e0eca40..298a031310 100644
> --- a/docs/interop/qcow2.txt
> +++ b/docs/interop/qcow2.txt
> @@ -25,6 +25,9 @@ The first cluster of a qcow2 image contains the file header:
>                       is stored (NB: The string is not null terminated). 0 if the
>                       image doesn't have a backing file.
>   
> +                    Note: backing files are incompatible with raw external data
> +                    files (auto-clear feature bit 1).
> +
>            16 - 19:   backing_file_size
>                       Length of the backing file name in bytes. Must not be
>                       longer than 1023 bytes. Undefined if the image doesn't have
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org



  reply	other threads:[~2020-04-13 18:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-10 12:18 [PATCH for-5.0] qcow2: Add incompatibility note between backing files and raw external data files Alberto Garcia
2020-04-13 18:11 ` Eric Blake [this message]
2020-04-14 15:31 ` Kevin Wolf
2020-04-14 16:10   ` Alberto Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1f31551c-2ac1-ac5b-01c4-005cca2cb2af@redhat.com \
    --to=eblake@redhat.com \
    --cc=berto@igalia.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).