From: Richard Henderson <richard.henderson@linaro.org>
To: Helge Deller <deller@gmx.de>, Laurent Vivier <laurent@vivier.eu>,
qemu-devel@nongnu.org
Subject: Re: [RFC][PATCH] accel/tcg: Use lookup_and_goto_ptr() for linux-user in translator_use_goto_tb()
Date: Sun, 30 Jul 2023 11:01:26 -0700 [thread overview]
Message-ID: <1f3bd7a5-ac39-1706-99f1-6ae56a7cf4a7@linaro.org> (raw)
In-Reply-To: <ZMakYpOgco2Ihg0G@p100>
On 7/30/23 10:56, Helge Deller wrote:
> +++ b/accel/tcg/translator.c
> @@ -124,8 +124,13 @@ bool translator_use_goto_tb(DisasContextBase *db, vaddr dest)
> return false;
> }
>
> +#ifndef CONFIG_USER_ONLY
> /* Check for the dest on the same page as the start of the TB. */
> return ((db->pc_first ^ dest) & TARGET_PAGE_MASK) == 0;
> +#else
> + /* linux-user doesn't need to fear pagefaults for exec swap-in */
> + return false;
> +#endif
> }
No, we still need to stop at pages for breakpoints.
r~
next prev parent reply other threads:[~2023-07-30 18:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-30 17:56 [RFC][PATCH] accel/tcg: Use lookup_and_goto_ptr() for linux-user in translator_use_goto_tb() Helge Deller
2023-07-30 18:01 ` Richard Henderson [this message]
2023-07-30 18:02 ` Richard Henderson
2023-07-30 18:19 ` Helge Deller
2023-07-30 20:03 ` Richard Henderson
2023-07-30 20:37 ` Helge Deller
2023-07-31 14:50 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f3bd7a5-ac39-1706-99f1-6ae56a7cf4a7@linaro.org \
--to=richard.henderson@linaro.org \
--cc=deller@gmx.de \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).