From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E2B6C001DF for ; Sun, 30 Jul 2023 18:11:54 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qQAjZ-0003UB-64; Sun, 30 Jul 2023 14:01:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQAjU-0003Te-QA for qemu-devel@nongnu.org; Sun, 30 Jul 2023 14:01:35 -0400 Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qQAjT-0000qb-8h for qemu-devel@nongnu.org; Sun, 30 Jul 2023 14:01:32 -0400 Received: by mail-pg1-x52c.google.com with SMTP id 41be03b00d2f7-563dc551518so2194148a12.2 for ; Sun, 30 Jul 2023 11:01:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690740089; x=1691344889; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lY/MbOqo8F1QNTOCDgcy+iMAjbyGBh1mxjiBaseHnN4=; b=xif6+BEnS2n+4fjKXKiWLE/xRLQaPgNKqnOZnHptqQaXx8VmCUVK9VnhLipZj56iyl hVctNDyx3rdzJOnFnzGykzqF4H2TXnHxPwEK746oWRo/Fgu+C+RfQxHIMZ8qW/bbk2Ci KnFU29DwnjI90uSBSpYAq9U3b8a06pa4yUZZj1FT3N2SFE7eJEa5T5f86JeLnteIEEsb ULnW6yTKKQLvDCulovEkGH6eKaOm+b1kIgq/WMPKJ2wPLS+RvXClz+7mcU2YAgwO6Hcc dv7p6pwGGVooBtKLj0QI7ITolGH45K4M/H7qGmFZ3UFOGKQLAkygEjiYNxdF3MuEeFi9 078g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690740089; x=1691344889; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lY/MbOqo8F1QNTOCDgcy+iMAjbyGBh1mxjiBaseHnN4=; b=MYDDcCHaj3pHGoCgHa50mtIp/80FZYSQiiokei+MnPuRZy0dhOfQE1Gs9lS/30XlkT Gc3ukEHIqd3enxLaBeECswvdDgzw55pPKwCEFhgsZuRRhMulp7rJV7xybDODvFplVKBm qmdglEJoM8rWn7EJ0wEcQ2W/3+oJoH/mZeJH3CZxChNIrYop1bfhVQCRv+LlmUQ4Pa08 mx2hQ6b+FjwBCfeYCNS0/MT7QE6dVtFasR1njZc4zdVyT+sJCIfg2GDEhaYuu5cKzlHb BuVttMR2SeH9JidA+h+/aw+Wf08ma071KYTaaTgVrn+3mIcGSrDyVdaEZb3+wol5DNvu /vPA== X-Gm-Message-State: ABy/qLaSoBaOWqxR7CuSGwOVKecv6eHrq8JIAhQ0a+zaU241PcZ8gGM0 U95K1sydLplFxr8nzKnOvH6mhFvWR90kFa7MHSw= X-Google-Smtp-Source: APBJJlH0yWqRDBmvM7Z49D19gZnb1DxVQ/3spo8Hn8YDxTMYZtI4njAlZvR+QItqs3apbeRQegqDBg== X-Received: by 2002:a17:90a:3e84:b0:267:f7eb:f12e with SMTP id k4-20020a17090a3e8400b00267f7ebf12emr7266354pjc.39.1690740088992; Sun, 30 Jul 2023 11:01:28 -0700 (PDT) Received: from ?IPV6:2602:47:d490:6901:a7b4:380e:e513:5ef2? ([2602:47:d490:6901:a7b4:380e:e513:5ef2]) by smtp.gmail.com with ESMTPSA id q9-20020a17090a68c900b00268385b0501sm4884633pjj.27.2023.07.30.11.01.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 30 Jul 2023 11:01:28 -0700 (PDT) Message-ID: <1f3bd7a5-ac39-1706-99f1-6ae56a7cf4a7@linaro.org> Date: Sun, 30 Jul 2023 11:01:26 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [RFC][PATCH] accel/tcg: Use lookup_and_goto_ptr() for linux-user in translator_use_goto_tb() Content-Language: en-US To: Helge Deller , Laurent Vivier , qemu-devel@nongnu.org References: From: Richard Henderson In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::52c; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52c.google.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.101, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 7/30/23 10:56, Helge Deller wrote: > +++ b/accel/tcg/translator.c > @@ -124,8 +124,13 @@ bool translator_use_goto_tb(DisasContextBase *db, vaddr dest) > return false; > } > > +#ifndef CONFIG_USER_ONLY > /* Check for the dest on the same page as the start of the TB. */ > return ((db->pc_first ^ dest) & TARGET_PAGE_MASK) == 0; > +#else > + /* linux-user doesn't need to fear pagefaults for exec swap-in */ > + return false; > +#endif > } No, we still need to stop at pages for breakpoints. r~