Re: [PATCH v5 2/3] backends: Initial support for SPDM socket support

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 7/3/24 01:58, Alistair Francis wrote:
> From: Huai-Cheng Kuo <hchkuo@avery-design.com.tw>
> 
> SPDM enables authentication, attestation and key exchange to assist in
> providing infrastructure security enablement. It's a standard published
> by the DMTF [1].
> 
> SPDM supports multiple transports, including PCIe DOE and MCTP.
> This patch adds support to QEMU to connect to an external SPDM
> instance.
> 
> SPDM support can be added to any QEMU device by exposing a
> TCP socket to a SPDM server. The server can then implement the SPDM
> decoding/encoding support, generally using libspdm [2].
> 
> This is similar to how the current TPM implementation works and means
> that the heavy lifting of setting up certificate chains, capabilities,
> measurements and complex crypto can be done outside QEMU by a well
> supported and tested library.
> 
> 1: https://www.dmtf.org/standards/SPDM
> 2: https://github.com/DMTF/libspdm
> 
> Signed-off-by: Huai-Cheng Kuo <hchkuo@avery-design.com.tw>
> Signed-off-by: Chris Browy <cbrowy@avery-design.com>
> Co-developed-by: Jonathan Cameron <Jonathan.cameron@huawei.com>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> [ Changes by WM
>   - Bug fixes from testing
> ]
> Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
> [ Changes by AF:
>   - Convert to be more QEMU-ified
>   - Move to backends as it isn't PCIe specific
> ]
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
>   MAINTAINERS                  |   6 +
>   include/sysemu/spdm-socket.h |  44 +++++++
>   backends/spdm-socket.c       | 216 +++++++++++++++++++++++++++++++++++
>   backends/Kconfig             |   4 +
>   backends/meson.build         |   2 +
>   5 files changed, 272 insertions(+)
>   create mode 100644 include/sysemu/spdm-socket.h
>   create mode 100644 backends/spdm-socket.c
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4183f2f3ab..a07706c225 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3395,6 +3395,12 @@ F: tests/qtest/*tpm*
>   F: docs/specs/tpm.rst
>   T: git https://github.com/stefanberger/qemu-tpm.git tpm-next
>   
> +SPDM
> +M: Alistair Francis <alistair.francis@wdc.com>
> +S: Maintained
> +F: backends/spdm-socket.c
> +F: include/sysemu/spdm-socket.h
> +
>   Checkpatch
>   S: Odd Fixes
>   F: scripts/checkpatch.pl
> diff --git a/include/sysemu/spdm-socket.h b/include/sysemu/spdm-socket.h
> new file mode 100644
> index 0000000000..24e6fccb83
> --- /dev/null
> +++ b/include/sysemu/spdm-socket.h
> @@ -0,0 +1,44 @@
> +/*
> + * QEMU SPDM socket support
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a copy
> + * of this software and associated documentation files (the "Software"), to deal
> + * in the Software without restriction, including without limitation the rights
> + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
> + * copies of the Software, and to permit persons to whom the Software is
> + * furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice shall be included in
> + * all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
> + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
> + * THE SOFTWARE.
> + */
> +
> +#ifndef SPDM_REQUESTER_H
> +#define SPDM_REQUESTER_H
> +
> +int spdm_socket_connect(uint16_t port, Error **errp);

Could we have a short description on what this function returns
and its arguments?

> +uint32_t spdm_socket_rsp(const int socket, uint32_t transport_type,
> +                         void *req, uint32_t req_len,
> +                         void *rsp, uint32_t rsp_len);

Ditto.

> +void spdm_socket_close(const int socket, uint32_t transport_type);
> +
> +#define SPDM_SOCKET_COMMAND_NORMAL                0x0001
> +#define SPDM_SOCKET_COMMAND_OOB_ENCAP_KEY_UPDATE  0x8001
> +#define SPDM_SOCKET_COMMAND_CONTINUE              0xFFFD
> +#define SPDM_SOCKET_COMMAND_SHUTDOWN              0xFFFE
> +#define SPDM_SOCKET_COMMAND_UNKOWN                0xFFFF
> +#define SPDM_SOCKET_COMMAND_TEST                  0xDEAD
> +
> +#define SPDM_SOCKET_TRANSPORT_TYPE_MCTP           0x01
> +#define SPDM_SOCKET_TRANSPORT_TYPE_PCI_DOE        0x02
> +
> +#define SPDM_SOCKET_MAX_MESSAGE_BUFFER_SIZE       0x1200
> +
> +#endif