From: Eric Blake <eblake@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] migration: fix crash in when incoming client channel setup fails
Date: Tue, 19 Jun 2018 13:18:24 -0500 [thread overview]
Message-ID: <1f44a357-4ba7-9dc3-4be6-9ed424d61b2f@redhat.com> (raw)
In-Reply-To: <20180619163552.18206-1-berrange@redhat.com>
On 06/19/2018 11:35 AM, Daniel P. Berrangé wrote:
> The way we determine if we can start the incoming migration was
> changed to use migration_has_all_channels() in:
>
> commit 428d89084c709e568f9cd301c2f6416a54c53d6d
> Author: Juan Quintela <quintela@redhat.com>
> Date: Mon Jul 24 13:06:25 2017 +0200
>
> migration: Create migration_has_all_channels
>
> This method in turn calls multifd_recv_all_channels_created()
> which is hardcoded to always return 'true' when multifd is
> not in use. This is a latent bug...
>
> ...activated in in a following commit where that return result
s/in in/in/
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-06-19 18:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 16:35 [Qemu-devel] [PATCH v2] migration: fix crash in when incoming client channel setup fails Daniel P. Berrangé
2018-06-19 16:40 ` Dr. David Alan Gilbert
2018-06-19 18:18 ` Eric Blake [this message]
2018-06-19 20:04 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f44a357-4ba7-9dc3-4be6-9ed424d61b2f@redhat.com \
--to=eblake@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).