From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD220C43603 for ; Wed, 18 Dec 2019 19:34:11 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 84E64227BF for ; Wed, 18 Dec 2019 19:34:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="f2Ur4Jku" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 84E64227BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59600 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihf5G-000892-CG for qemu-devel@archiver.kernel.org; Wed, 18 Dec 2019 14:34:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34854) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihf4E-00079S-3U for qemu-devel@nongnu.org; Wed, 18 Dec 2019 14:33:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihf4C-0000jK-6J for qemu-devel@nongnu.org; Wed, 18 Dec 2019 14:33:05 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:29912 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ihf4B-0000dm-Rd for qemu-devel@nongnu.org; Wed, 18 Dec 2019 14:33:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576697582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:openpgp:openpgp; bh=H3XB9LtpzmgmkoH16B64W+jHq4hClZChffgQO24Taxg=; b=f2Ur4JkusSUs1zCIJpGKwqXaxMW3cOfZpAdZmy2a5yQ5gbAy9D3A5kStHEVbNlmesdzWFa JtkMv2PL0UyhXvneh9h+tckkLUE0+nZwIE5M2apk4BwaMzIe+66YIWTGM772EnUswdD0wu XpqC2gLQYdCWj48EqobFmlmee4YV0JI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-148-8BShiiLxMCaMY3Xu5ZA6RA-1; Wed, 18 Dec 2019 14:32:59 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 251441005502; Wed, 18 Dec 2019 19:32:58 +0000 (UTC) Received: from thuth.remote.csb (ovpn-116-120.ams2.redhat.com [10.36.116.120]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 31D1F19C58; Wed, 18 Dec 2019 19:32:52 +0000 (UTC) Subject: Re: [RFC PATCH v2 6/6] hw/pci-host/designware: Remove unuseful FALLTHROUGH comment To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20191218192526.13845-1-philmd@redhat.com> <20191218192526.13845-7-philmd@redhat.com> From: Thomas Huth Openpgp: preference=signencrypt Message-ID: <1f498b45-f32d-7883-69dc-8a75a39a89bd@redhat.com> Date: Wed, 18 Dec 2019 20:32:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191218192526.13845-7-philmd@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: 8BShiiLxMCaMY3Xu5ZA6RA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , Peter Maydell , qemu-arm@nongnu.org, Peter Chubb , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 18/12/2019 20.25, Philippe Mathieu-Daud=C3=A9 wrote: > We don't need to explicit this obvious switch fall through. > Stay consistent with the rest of the codebase. >=20 > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > Cc: Peter Chubb > Cc: Markus Armbruster > Cc: Peter Maydell > Cc: Andrey Smirnov > Cc: qemu-arm@nongnu.org > --- > hw/pci-host/designware.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/hw/pci-host/designware.c b/hw/pci-host/designware.c > index 71e9b0d9b5..dd245516dd 100644 > --- a/hw/pci-host/designware.c > +++ b/hw/pci-host/designware.c > @@ -182,7 +182,7 @@ designware_pcie_root_config_read(PCIDevice *d, uint32= _t address, int len) > break; > =20 > case DESIGNWARE_PCIE_ATU_CR1: > - case DESIGNWARE_PCIE_ATU_CR2: /* FALLTHROUGH */ > + case DESIGNWARE_PCIE_ATU_CR2: > val =3D viewport->cr[(address - DESIGNWARE_PCIE_ATU_CR1) / > sizeof(uint32_t)]; > break; >=20 Reviewed-by: Thomas Huth