From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34698) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d1C0d-0002Nc-7n for qemu-devel@nongnu.org; Thu, 20 Apr 2017 09:20:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d1C0c-0006nQ-6r for qemu-devel@nongnu.org; Thu, 20 Apr 2017 09:20:31 -0400 References: <20170419222258.13415-1-eblake@redhat.com> <87k26fffxa.fsf@dusky.pond.sub.org> <20170420120922.GJ20955@redhat.com> From: Eric Blake Message-ID: <1f4e72ed-fab1-7099-768e-2a111df3a633@redhat.com> Date: Thu, 20 Apr 2017 08:20:11 -0500 MIME-Version: 1.0 In-Reply-To: <20170420120922.GJ20955@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MJ1tsuo055DBeRBh8xXxl1H5JDCn29vB7" Subject: Re: [Qemu-devel] [PATCH v2] event: Add source information to SHUTDOWN List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , Markus Armbruster Cc: Peter Maydell , "open list:Overall" , "Michael S. Tsirkin" , Mark Cave-Ayland , qemu-devel@nongnu.org, Cornelia Huck , Gerd Hoffmann , "Edgar E. Iglesias" , Rob Herring , Stefano Stabellini , Magnus Damm , Alexander Graf , Christian Borntraeger , Anthony Perard , "open list:X86" , David Gibson , Artyom Tarasenko , Eduardo Habkost , Stefan Weil , Alistair Francis , "open list:Calxeda Highbank" , Jan Kiszka , Paolo Bonzini , Scott Wood , Richard Henderson , Paul Burton , Max Filippov , Marcelo Tosatti , Michael Walle , "open list:New World" , Yongbok Kim , Igor Mammedov , Aurelien Jarno This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --MJ1tsuo055DBeRBh8xXxl1H5JDCn29vB7 From: Eric Blake To: "Daniel P. Berrange" , Markus Armbruster Cc: Peter Maydell , "open list:Overall" , "Michael S. Tsirkin" , Mark Cave-Ayland , qemu-devel@nongnu.org, Cornelia Huck , Gerd Hoffmann , "Edgar E. Iglesias" , Rob Herring , Stefano Stabellini , Magnus Damm , Alexander Graf , Christian Borntraeger , Anthony Perard , "open list:X86" , David Gibson , Artyom Tarasenko , Eduardo Habkost , Stefan Weil , Alistair Francis , "open list:Calxeda Highbank" , Jan Kiszka , Paolo Bonzini , Scott Wood , Richard Henderson , Paul Burton , Max Filippov , Marcelo Tosatti , Michael Walle , "open list:New World" , Yongbok Kim , Igor Mammedov , Aurelien Jarno Message-ID: <1f4e72ed-fab1-7099-768e-2a111df3a633@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] event: Add source information to SHUTDOWN References: <20170419222258.13415-1-eblake@redhat.com> <87k26fffxa.fsf@dusky.pond.sub.org> <20170420120922.GJ20955@redhat.com> In-Reply-To: <20170420120922.GJ20955@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/20/2017 07:09 AM, Daniel P. Berrange wrote: >>> +++ b/qapi/event.json >>> @@ -10,6 +10,10 @@ >>> # Emitted when the virtual machine has shut down, indicating that qe= mu is >>> # about to exit. >>> # >>> +# @guest: If true, the shutdown was triggered by a guest request (su= ch as >>> +# executing a halt instruction) rather than a host request (such as = sending >>> +# qemu a SIGINT). (since 2.10) >>> +# >> >> "executing a halt instruction" suggests "halt" is a machine instructio= n. Which is indeed what most of the places I patched to pass 'true' are emulating - the machine halt instruction. >> I think you mean /usr/sbin/halt. Suggest something like "executing a >> halt command". >=20 > Well technically /usr/sbin/halt just terminates all processes / kernel = and > halts CPUs, but the virtual machine is still active (and a 'reset' in t= he > monitor can start it again. /usr/sbin/poweroff is what actually does th= e > ACPI poweroff to trigger QEMU to exit[1] I'm thinking of this wording: triggered by a guest request (such as the guest running /usr/sbin/poweroff to trigger an ACPI shutdown or machine halt instructio= n) --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org --MJ1tsuo055DBeRBh8xXxl1H5JDCn29vB7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJY+LWLAAoJEKeha0olJ0NqMFMIAJ+mxZJviG+ZHLY7f0P+nZHw lSmYS3rDIUtpTlg/L41kGp2qaa/4Le0Dm8SjVIOcfXH0Q0ZF9Lz2D5TKdJpOwCpO 9xI2aJTR2T5VZS8eiV4Cwb58EnwCkm2V0xSTigug1B3/mc0HjNyrCrIBmoenXGy9 svhwYAkIi4uJoLqvEPBa3b97TUYgCNcYFLewAEwehQv5eYyaveMLJ0Gn7srfS2tb 8eRhZca425Y47DQWX6W6n3YHQSvRkKgPuuIR03dd6comUBYREJzkE4cwUPCRdPut QaJocb0qiCjL+tSQe104bffeBeuQmnymmSbIdEC7C+Y5M5BXsg6k8//VARsBmhw= =qiAs -----END PGP SIGNATURE----- --MJ1tsuo055DBeRBh8xXxl1H5JDCn29vB7--