From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E73F0CD98E6 for ; Wed, 11 Oct 2023 02:57:02 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qqPOa-0000BS-Dv; Tue, 10 Oct 2023 22:56:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqPOY-0000BC-To for qemu-devel@nongnu.org; Tue, 10 Oct 2023 22:56:22 -0400 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qqPOX-00087y-0t for qemu-devel@nongnu.org; Tue, 10 Oct 2023 22:56:22 -0400 Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-9a6190af24aso1101256666b.0 for ; Tue, 10 Oct 2023 19:56:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696992979; x=1697597779; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Lfejmu0fed9jzJQJl9bYK7nnwauq98g5xtw+qWD1PB4=; b=zN0pK2RJkVTkDossO+3x4VCIzekUx7GTD1lNPODcoVKthr5kdY6D6+c+YjWMcyKUoF 1vzD8ofVoIe8guVJLP0/3sAuDmWTVUPm+sh/4wKGT+bYpcI7cYUQCH9KGjoNVJZvrKPH gSGT4C4VBiAyYFGzIDNtO3ddg3jNTsIuUxsuV0AlXncquFgMYIysBxk5qhJXVel8bUpx tkFNXMoSLRbnZcgBnK7RN/oPZtKs4G4KAQ66P8YqiLAPC1BB3rOAV6UycoIgRA8GXPSU ubrkKUMWuxeuKqvnAmjToW8erISBtSoOrdaVGs94ugN5QHKjNQBXmPdeaDhUoEdAFL5v KaBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696992979; x=1697597779; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Lfejmu0fed9jzJQJl9bYK7nnwauq98g5xtw+qWD1PB4=; b=FKHGgqKL+MVaTnGHNZMY5F8e4PZJDwkWRJh4YufI2pD7KuIMT135qa+5DSl+gaSnd6 VQWjAvW6DZGvz8MnhJBoBHUoWu52oOLI90X41ydFoaXoK+7l0UQx3/m4xxatOrJ2jGE/ KnlJFiEhLpwiyAyKt8/OQqH6Q+lE7ovQt1Xfgz1TOlAkCyPcAY+oaNYWedYH7jwwelGP 37oB6kjXNvx6gaRQdsaGTG7GvGKPjBUZ2yKVJGW/1AThpzDZclvswtmP+zjpONzm37tU NWHVOoCyTKb91obbKPN0AtXdnNUU3SpEyEG33FUwafqZUKdbGRLNoKujxMBw+Za7yzCn t7BQ== X-Gm-Message-State: AOJu0Yy/o/Hl5aF9e0v3OkBF/87RGMbuWSFUBgxaWMcYAYjIYxjwr+yY z+qp15UcVi02NqqneU87hyCg7g== X-Google-Smtp-Source: AGHT+IEUiOgBTZwsDp2qaWW9mB0p6/rF7r1VbnY60qxYtxdDpcO86CsSe1aSdzoojgJBUbOlxkKJkw== X-Received: by 2002:a17:906:846c:b0:9b6:8155:cbf4 with SMTP id hx12-20020a170906846c00b009b68155cbf4mr17170768ejc.47.1696992979194; Tue, 10 Oct 2023 19:56:19 -0700 (PDT) Received: from [192.168.69.115] (mdq11-h01-176-173-161-48.dsl.sta.abo.bbox.fr. [176.173.161.48]) by smtp.gmail.com with ESMTPSA id si5-20020a170906cec500b009ae0042e48bsm9129261ejb.5.2023.10.10.19.56.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Oct 2023 19:56:18 -0700 (PDT) Message-ID: <1f552f71-3b47-a2be-67c5-fdca86bf59f7@linaro.org> Date: Wed, 11 Oct 2023 04:56:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH RFC v4 4/9] target/loongarch: Implement kvm get/set registers Content-Language: en-US To: xianglai li , qemu-devel@nongnu.org, kvm@vger.kernel.org Cc: Tianrui Zhao , "Michael S. Tsirkin" , Cornelia Huck , Paolo Bonzini , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Thomas Huth , Richard Henderson , Peter Maydell , Bibo Mao , Song Gao , Xiaojuan Yang References: From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::635; envelope-from=philmd@linaro.org; helo=mail-ej1-x635.google.com X-Spam_score_int: -53 X-Spam_score: -5.4 X-Spam_bar: ----- X-Spam_report: (-5.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-3.339, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hi Li and Zhao, On 9/10/23 11:01, xianglai li wrote: > From: Tianrui Zhao > > Implement kvm_arch_get/set_registers interfaces, many regs > can be get/set in the function, such as core regs, csr regs, > fpu regs, mp state, etc. > > Cc: "Michael S. Tsirkin" > Cc: Cornelia Huck > Cc: Paolo Bonzini > Cc: "Marc-André Lureau" > Cc: "Daniel P. Berrangé" > Cc: Thomas Huth > Cc: "Philippe Mathieu-Daudé" > Cc: Richard Henderson > Cc: Peter Maydell > Cc: Bibo Mao > Cc: Song Gao > Cc: Xiaojuan Yang > Cc: Tianrui Zhao > > Signed-off-by: Tianrui Zhao > Signed-off-by: xianglai li > --- > meson.build | 1 + > target/loongarch/cpu.c | 3 + > target/loongarch/cpu.h | 2 + > target/loongarch/kvm.c | 406 +++++++++++++++++++++++++++++++++- > target/loongarch/trace-events | 13 ++ > target/loongarch/trace.h | 1 + > 6 files changed, 424 insertions(+), 2 deletions(-) > create mode 100644 target/loongarch/trace-events > create mode 100644 target/loongarch/trace.h > +static int kvm_larch_getq(CPUState *cs, uint64_t reg_id, > + uint64_t *addr) > +{ > + struct kvm_one_reg csrreg = { > + .id = reg_id, > + .addr = (uintptr_t)addr > + }; > + > + return kvm_vcpu_ioctl(cs, KVM_GET_ONE_REG, &csrreg); > +} This is kvm_get_one_reg(). > +static int kvm_larch_putq(CPUState *cs, uint64_t reg_id, > + uint64_t *addr) > +{ > + struct kvm_one_reg csrreg = { > + .id = reg_id, > + .addr = (uintptr_t)addr > + }; > + > + return kvm_vcpu_ioctl(cs, KVM_SET_ONE_REG, &csrreg); > +} This is kvm_set_one_reg(). > + > +#define KVM_GET_ONE_UREG64(cs, ret, regidx, addr) \ > + ({ \ > + err = kvm_larch_getq(cs, KVM_IOC_CSRID(regidx), addr); \ > + if (err < 0) { \ > + ret = err; \ > + trace_kvm_failed_get_csr(regidx, strerror(errno)); \ > + } \ > + }) > + > +#define KVM_PUT_ONE_UREG64(cs, ret, regidx, addr) \ > + ({ \ > + err = kvm_larch_putq(cs, KVM_IOC_CSRID(regidx), addr); \ > + if (err < 0) { \ > + ret = err; \ > + trace_kvm_failed_put_csr(regidx, strerror(errno)); \ > + } \ > + })