From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: famz@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu_iotests: Remove _readlink()
Date: Fri, 21 Apr 2017 08:27:48 -0500 [thread overview]
Message-ID: <1f5db49f-0791-44a8-8482-59068eb65b2d@redhat.com> (raw)
In-Reply-To: <1492761662-5644-1-git-send-email-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 598 bytes --]
On 04/21/2017 03:01 AM, Kevin Wolf wrote:
> It is unused.
Might be worth also mentioning that it was the file's only client of
perl, so removing it also makes it easier to justify removing a check
for $PERL.
>
> Suggestetd-by: Fam Zheng <famz@redhat.com>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> tests/qemu-iotests/common.config | 18 ------------------
> 1 file changed, 18 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-04-21 13:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 8:01 [Qemu-devel] [PATCH] qemu_iotests: Remove _readlink() Kevin Wolf
2017-04-21 8:15 ` Fam Zheng
2017-04-21 13:27 ` Eric Blake [this message]
2017-04-22 17:35 ` [Qemu-devel] [Qemu-block] " Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f5db49f-0791-44a8-8482-59068eb65b2d@redhat.com \
--to=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).