qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Akihiko Odaki <akihiko.odaki@daynix.com>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
	"Mikhail Tyutin" <m.tyutin@yadro.com>,
	"Aleksandr Anenkov" <a.anenkov@yadro.com>,
	qemu-devel@nongnu.org, "Eduardo Habkost" <eduardo@habkost.net>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Yanan Wang" <wangyanan55@huawei.com>
Subject: Re: [PATCH v7 14/18] cpu: Call plugin hooks only when ready
Date: Tue, 12 Sep 2023 10:46:05 +0200	[thread overview]
Message-ID: <1f64f982-95fc-786d-1217-856a62335eed@linaro.org> (raw)
In-Reply-To: <20230912071206.30751-15-akihiko.odaki@daynix.com>

Hi Akihiko,

On 12/9/23 09:12, Akihiko Odaki wrote:
> The initialization and exit hooks will not affect the state of vCPU,

What about:

  qemu_plugin_vcpu_init_hook()
    -> plugin_cpu_update__locked()
       -> plugin_cpu_update__async()
          -> bitmap_copy(cpu->plugin_mask, ...)
             tcg_flush_jmp_cache(cpu)
             -> qatomic_set(&cpu->tb_jmp_cache->array[i].tb, ...)

?

> but they may depend on the state of vCPU. Therefore, it's better to
> call plugin hooks after the vCPU state is fully initialized and before
> it gets uninitialized.
> 
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
>   cpu.c                | 11 -----------
>   hw/core/cpu-common.c | 10 ++++++++++
>   2 files changed, 10 insertions(+), 11 deletions(-)



  reply	other threads:[~2023-09-12  8:47 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-12  7:11 [PATCH v7 00/18] plugins: Allow to read registers Akihiko Odaki
2023-09-12  7:11 ` [PATCH v7 01/18] gdbstub: Add num_regs member to GDBFeature Akihiko Odaki
2023-09-12  7:11 ` [PATCH v7 02/18] gdbstub: Introduce gdb_find_static_feature() Akihiko Odaki
2023-09-12  7:11 ` [PATCH v7 03/18] hw/core/cpu: Replace gdb_core_xml_file with gdb_core_feature Akihiko Odaki
2023-09-12  7:11 ` [PATCH v7 04/18] gdbstub: Introduce GDBFeatureBuilder Akihiko Odaki
2023-09-12  7:11 ` [PATCH v7 05/18] target/arm: Use GDBFeature for dynamic XML Akihiko Odaki
2023-09-12  7:11 ` [PATCH v7 06/18] target/ppc: " Akihiko Odaki
2023-09-12  7:11 ` [PATCH v7 07/18] target/riscv: " Akihiko Odaki
2023-09-12  7:11 ` [PATCH v7 08/18] gdbstub: Use GDBFeature for gdb_register_coprocessor Akihiko Odaki
2023-09-12  7:11 ` [PATCH v7 09/18] gdbstub: Use GDBFeature for GDBRegisterState Akihiko Odaki
2023-09-12  7:11 ` [PATCH v7 10/18] gdbstub: Simplify XML lookup Akihiko Odaki
2023-09-12  7:11 ` [PATCH v7 11/18] hw/core/cpu: Remove gdb_get_dynamic_xml member Akihiko Odaki
2023-09-12  7:11 ` [PATCH v7 12/18] gdbstub: Add members to identify registers to GDBFeature Akihiko Odaki
2023-09-12  7:11 ` [PATCH v7 13/18] gdbstub: Expose functions to read registers Akihiko Odaki
2023-09-12  7:12 ` [PATCH v7 14/18] cpu: Call plugin hooks only when ready Akihiko Odaki
2023-09-12  8:46   ` Philippe Mathieu-Daudé [this message]
2023-09-12 22:53     ` Akihiko Odaki
2023-09-12  7:12 ` [PATCH v7 15/18] plugins: Allow to read registers Akihiko Odaki
2023-09-12  7:12 ` [PATCH v7 16/18] contrib/plugins: Allow to log registers Akihiko Odaki
2023-09-12  7:12 ` [PATCH v7 17/18] plugins: Support C++ Akihiko Odaki
2023-09-12  7:12 ` [PATCH v7 18/18] contrib/plugins: Add cc plugin Akihiko Odaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1f64f982-95fc-786d-1217-856a62335eed@linaro.org \
    --to=philmd@linaro.org \
    --cc=a.anenkov@yadro.com \
    --cc=akihiko.odaki@daynix.com \
    --cc=alex.bennee@linaro.org \
    --cc=eduardo@habkost.net \
    --cc=m.tyutin@yadro.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wangyanan55@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).