From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH 6/6] tcg/sparc64: Use 'z' constraint
Date: Thu, 13 Feb 2025 16:53:12 +0100 [thread overview]
Message-ID: <1f69ca30-64f4-4f97-af89-f0933d11f6e3@linaro.org> (raw)
In-Reply-To: <20250212034617.1079324-7-richard.henderson@linaro.org>
On 12/2/25 04:46, Richard Henderson wrote:
> Replace target-specific 'Z' with generic 'z'.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tcg/sparc64/tcg-target-con-set.h | 12 ++++++------
> tcg/sparc64/tcg-target-con-str.h | 1 -
> tcg/sparc64/tcg-target.c.inc | 12 ++++++------
> 3 files changed, 12 insertions(+), 13 deletions(-)
> diff --git a/tcg/sparc64/tcg-target-con-str.h b/tcg/sparc64/tcg-target-con-str.h
> index 0577ec4942..2f033b3ac2 100644
> --- a/tcg/sparc64/tcg-target-con-str.h
> +++ b/tcg/sparc64/tcg-target-con-str.h
> @@ -16,4 +16,3 @@ REGS('r', ALL_GENERAL_REGS)
> */
> CONST('I', TCG_CT_CONST_S11)
> CONST('J', TCG_CT_CONST_S13)
> -CONST('Z', TCG_CT_CONST_ZERO)
Squashing:
-- >8 --
diff --git a/tcg/sparc64/tcg-target.c.inc b/tcg/sparc64/tcg-target.c.inc
index 733cb516512..69df3c2a17e 100644
--- a/tcg/sparc64/tcg-target.c.inc
+++ b/tcg/sparc64/tcg-target.c.inc
@@ -76,7 +76,6 @@ static const char * const
tcg_target_reg_names[TCG_TARGET_NB_REGS] = {
#define TCG_CT_CONST_S11 0x100
#define TCG_CT_CONST_S13 0x200
-#define TCG_CT_CONST_ZERO 0x400
#define ALL_GENERAL_REGS MAKE_64BIT_MASK(0, 32)
@@ -340,9 +339,7 @@ static bool tcg_target_const_match(int64_t val, int ct,
val = (int32_t)val;
}
- if ((ct & TCG_CT_CONST_ZERO) && val == 0) {
- return 1;
- } else if ((ct & TCG_CT_CONST_S11) && check_fit_tl(val, 11)) {
+ if ((ct & TCG_CT_CONST_S11) && check_fit_tl(val, 11)) {
return 1;
} else if ((ct & TCG_CT_CONST_S13) && check_fit_tl(val, 13)) {
return 1;
---
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2025-02-13 15:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 3:46 [PATCH 0/6] tcg: Introduce constraint for zero register Richard Henderson
2025-02-12 3:46 ` [PATCH 1/6] tcg: Introduce the 'z' constraint for a hardware " Richard Henderson
2025-02-13 15:45 ` Philippe Mathieu-Daudé
2025-02-13 17:15 ` Richard Henderson
2025-02-12 3:46 ` [PATCH 2/6] tcg/aarch64: Use 'z' constraint Richard Henderson
2025-02-16 13:06 ` Philippe Mathieu-Daudé
2025-02-12 3:46 ` [PATCH 3/6] tcg/loongarch64: " Richard Henderson
2025-02-13 15:47 ` Philippe Mathieu-Daudé
2025-02-12 3:46 ` [PATCH 4/6] tcg/mips: " Richard Henderson
2025-02-13 15:47 ` Philippe Mathieu-Daudé
2025-02-12 3:46 ` [PATCH 5/6] tcg/riscv: " Richard Henderson
2025-02-13 15:50 ` Philippe Mathieu-Daudé
2025-02-13 15:54 ` Philippe Mathieu-Daudé
2025-02-12 3:46 ` [PATCH 6/6] tcg/sparc64: " Richard Henderson
2025-02-13 15:53 ` Philippe Mathieu-Daudé [this message]
2025-02-15 20:06 ` [PATCH 0/6] tcg: Introduce constraint for zero register Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f69ca30-64f4-4f97-af89-f0933d11f6e3@linaro.org \
--to=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).