From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [PATCH] hw/arm: Move raspberrypi-fw-defs.h to the include/hw/arm/ folder
Date: Thu, 12 Oct 2023 12:55:45 +0200 [thread overview]
Message-ID: <1f6a6f32-80aa-4a7f-9e33-72d1ca9984dd@redhat.com> (raw)
In-Reply-To: <788f54e1-3f2f-f24d-63cf-172efc605823@linaro.org>
On 12/10/2023 10.22, Philippe Mathieu-Daudé wrote:
> On 12/10/23 09:34, Thomas Huth wrote:
>> The file is obviously related to the raspberrypi machine, so
>> it should reside in hw/arm/ instead of hw/misc/.
>
> Not quite. These are the VideoCore DSP definitions. Firmware
> running on SoC including a VC can use this syscall-like interface.
>
> FWIW there are a pair of QEMU VC implementations on GitHub.
>
> Anyhow, preferably rewording the description,
So could you suggest a different wording instead? It's still "related to the
raspberypi machine", isn't it?
> Acked-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Thanks,
Thomas
next prev parent reply other threads:[~2023-10-12 10:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 7:34 [PATCH] hw/arm: Move raspberrypi-fw-defs.h to the include/hw/arm/ folder Thomas Huth
2023-10-12 7:54 ` Alex Bennée
2023-10-12 8:22 ` Philippe Mathieu-Daudé
2023-10-12 10:55 ` Thomas Huth [this message]
2023-10-16 16:26 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f6a6f32-80aa-4a7f-9e33-72d1ca9984dd@redhat.com \
--to=thuth@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).