qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Claudio Fontana <cfontana@suse.de>
To: David Gibson <david@gibson.dropbear.id.au>,
	Peter Maydell <peter.maydell@linaro.org>,
	Philippe Mathieu-Daude <philmd@redhat.com>
Cc: Laurent Vivier <laurent@vivier.eu>,
	Alex Bennee <alex.bennee@linaro.org>,
	Markus Armbruster <armbru@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH v5 0/2] Makefile: libfdt: build only the strict necessary
Date: Mon, 1 Jun 2020 13:28:40 +0200	[thread overview]
Message-ID: <1f70e2fb-a1f4-29af-c9e6-38b178fa26ca@suse.de> (raw)
In-Reply-To: <20200518160319.18861-1-cfontana@suse.de>

Hello all,

is this queued somewhere?

Thanks,

Claudio

On 5/18/20 6:03 PM, Claudio Fontana wrote:
> v4 -> v5:
> 
> * include the dtc submodule update commit in the 1/2 patch
> 
> v3 -> v4: NB! only useful when updating to latest dtc (not in QEMU yet)
> 
> * changed the approach to leverage new upstream dtc Makefile,
>   needs dtc submodule update to include upstream dtc commit
>   85e5d839847af54efab170f2b1331b2a6421e647.
> 
> * LIBFDT_srcdir does not exist anymore in upstream dtc: it is also
>   not used anymore.
> 
> * LIBFDT_lib: need to avoid building libfdt.so at least for now, so pass as
>   empty to avoid building the .so. This is to avoid breaking existing
>   trees with objects already compiled without -fPIC.
> 
> * clean: no need to make dtc clean target, every artifact is captured by
>   global clean rule
> 
> v2 -> v3:
> 
> * changed into a 2 patch series; in the second patch we remove the old
>   compatibility gunks that were meant for removal some time after 4.1.
> 
> * renamed the libfdt PHONY rule to dtc/all, with the intent to make
>   existing working trees forward and backward compatible across the change.
> 
> v1 -> v2:
> 
> * fix error generated when running UNCHECKED_GOALS without prior configure,
>   for example during make docker-image-fedora. Without configure, DSOSUF is
>   empty, and the module pattern rule in rules.mak that uses this variable
>   can match too much; provide a default in the Makefile to avoid it.
> 
> * only attempt to build the archive when there is a non-empty list of objects.
>   This could be done in general for the %.a: pattern in rules.mak, but maybe
>   there are valid reasons to build an empty .a?
> 
> * removed some intermediate variables that did not add much value
>   (LIBFDT_srcdir, LIBFDT_archive)
> 
> Tested locally with 3 VPATH configurations (no-, VPATH, VPATH in src subdir),
> and with docker-image-fedora, docker-test-debug@fedora that failed before.
> 
> Claudio Fontana (2):
>   Makefile: libfdt: build only the strict necessary
>   Makefile: remove old compatibility gunks
> 
>  Makefile  | 32 ++++++++++++++++----------------
>  configure |  6 +-----
>  rules.mak |  2 ++
>  3 files changed, 19 insertions(+), 21 deletions(-)
> 



  parent reply	other threads:[~2020-06-01 11:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-18 16:03 [PATCH v5 0/2] Makefile: libfdt: build only the strict necessary Claudio Fontana
2020-05-18 16:03 ` [PATCH v5 1/2] Makefile: dtc: update, build the libfdt target Claudio Fontana
2020-05-18 16:03 ` [PATCH v5 2/2] Makefile: remove old compatibility gunks Claudio Fontana
2020-06-01 11:28 ` Claudio Fontana [this message]
2020-06-07  6:53   ` [PATCH v5 0/2] Makefile: libfdt: build only the strict necessary Thomas Huth
2020-06-08  9:52     ` David Gibson
2020-06-08 11:14       ` Claudio Fontana
2020-06-10  5:02         ` David Gibson
  -- strict thread matches above, loose matches on Subject: below --
2020-05-18 16:02 Claudio Fontana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1f70e2fb-a1f4-29af-c9e6-38b178fa26ca@suse.de \
    --to=cfontana@suse.de \
    --cc=alex.bennee@linaro.org \
    --cc=armbru@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=laurent@vivier.eu \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).