From: Paolo Bonzini <pbonzini@redhat.com>
To: "Marek Dolata - mkdolata@us.ibm.com" <mkdolata@us.ibm.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
"qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
"Doug Gale" <doug16k@gmail.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH v4] target/i386: Fix handling of k_gs_base register in 32-bit mode in gdbstub
Date: Tue, 7 Jan 2020 14:29:00 +0100 [thread overview]
Message-ID: <1f942e38-d3bf-0d12-89fe-0ccf72f763d0@redhat.com> (raw)
In-Reply-To: <4afa19236529458282794f682dfac556@us.ibm.com>
On 29/12/19 03:48, Marek Dolata - mkdolata@us.ibm.com wrote:
> Fixes: corrects clobbering of registers appearing after k_gs_base
> Buglink: https://bugs.launchpad.net/qemu/+bug/1857640
>
> Signed-off-by: Marek Dolata <mkdolata@us.ibm.com>
Queued. Note that I had to apply the patch by hand since you probably did
some cut-and-paste job. I also added a meaningful commit message:
gdb-xml/i386-32bit.xml includes the k_gs_base register too, so we have to
handle it even if TARGET_X86_64 is not defined. This is already done in
x86_cpu_gdb_read_register, but not in x86_cpu_gdb_write_register where the
incorrect return value causes all registers after it to be clobbered.
Fixes https://bugs.launchpad.net/qemu/+bug/1857640.
Thanks,
Paolo
prev parent reply other threads:[~2020-01-07 14:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-29 2:48 [PATCH v4] target/i386: Fix handling of k_gs_base register in 32-bit mode in gdbstub Marek Dolata - mkdolata@us.ibm.com
2020-01-07 13:29 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f942e38-d3bf-0d12-89fe-0ccf72f763d0@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=doug16k@gmail.com \
--cc=ehabkost@redhat.com \
--cc=mkdolata@us.ibm.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).