From: Thomas Huth <thuth@redhat.com>
To: "Collin L. Walling" <walling@linux.vnet.ibm.com>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Cc: frankja@linux.vnet.ibm.com, borntraeger@de.ibm.com,
alifm@linux.vnet.ibm.com, david@redhat.com, cohuck@redhat.com
Subject: Re: [Qemu-devel] [qemu-s390x] [PATCH v4 07/10] s390-ccw: read stage2 boot loader data to find menu
Date: Fri, 26 Jan 2018 10:50:12 +0100 [thread overview]
Message-ID: <1fb0b863-0b5b-120e-7f19-093ecdb3a93c@redhat.com> (raw)
In-Reply-To: <994e3f5e-24e1-834a-5519-775a819d73c8@linux.vnet.ibm.com>
On 25.01.2018 16:49, Collin L. Walling wrote:
> On 01/25/2018 10:25 AM, Thomas Huth wrote:
>> On 23.01.2018 19:26, Collin L. Walling wrote:
>>> Read the stage2 boot loader data block-by-block. We scan the
>>> current block for the string "zIPL" to detect the start of the
>>> boot menu banner. We then load the adjacent blocks (previous
>>> block and next block) to account for the possibility of menu
>>> data spanning multiple blocks.
>>>
>>> Signed-off-by: Collin L. Walling <walling@linux.vnet.ibm.com>
>>> ---
>>> pc-bios/s390-ccw/bootmap.c | 94
>>> +++++++++++++++++++++++++++++++++++++++++++---
>>> pc-bios/s390-ccw/bootmap.h | 1 +
>>> pc-bios/s390-ccw/menu.c | 5 +++
>>> pc-bios/s390-ccw/menu.h | 1 +
>>> 4 files changed, 96 insertions(+), 5 deletions(-)
>> Looks good to me now!
>>
>> Reviewed-by: Thomas Huth <thuth@redhat.com>
>>
> Thanks! The only change I plan on is moving the Stage1b struct declaration
> to this patch, as per your suggestion on another patch review.
Sure, feel free to keep my R-b in that case, too.
Thomas
next prev parent reply other threads:[~2018-01-26 9:50 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 18:26 [Qemu-devel] [PATCH v4 00/10] Interactive Boot Menu for DASD and SCSI Guests on s390x Collin L. Walling
2018-01-23 18:26 ` [Qemu-devel] [PATCH v4 01/10] s390-ccw: refactor boot map table code Collin L. Walling
2018-01-25 10:07 ` Thomas Huth
2018-01-25 14:54 ` [Qemu-devel] [qemu-s390x] " Collin L. Walling
2018-01-23 18:26 ` [Qemu-devel] [PATCH v4 02/10] s390-ccw: refactor eckd_block_num to use CHS Collin L. Walling
2018-01-25 11:06 ` Thomas Huth
2018-01-25 11:17 ` Cornelia Huck
2018-01-25 14:55 ` [Qemu-devel] [qemu-s390x] " Collin L. Walling
2018-01-23 18:26 ` [Qemu-devel] [PATCH v4 03/10] s390-ccw: refactor IPL structs Collin L. Walling
2018-01-25 11:39 ` Thomas Huth
2018-01-25 15:13 ` [Qemu-devel] [qemu-s390x] " Collin L. Walling
2018-01-23 18:26 ` [Qemu-devel] [PATCH v4 04/10] s390-ccw: update libc Collin L. Walling
2018-01-23 19:23 ` Eric Blake
2018-01-23 22:33 ` [Qemu-devel] [qemu-s390x] " Collin L. Walling
2018-01-25 12:06 ` Thomas Huth
2018-01-25 15:08 ` Eric Blake
2018-01-25 15:19 ` Collin L. Walling
2018-01-23 18:26 ` [Qemu-devel] [PATCH v4 05/10] s390-ccw: parse and set boot menu options Collin L. Walling
2018-01-23 18:26 ` [Qemu-devel] [PATCH v4 06/10] s390-ccw: set up interactive boot menu parameters Collin L. Walling
2018-01-25 13:12 ` Thomas Huth
2018-01-23 18:26 ` [Qemu-devel] [PATCH v4 07/10] s390-ccw: read stage2 boot loader data to find menu Collin L. Walling
2018-01-25 15:25 ` Thomas Huth
2018-01-25 15:49 ` [Qemu-devel] [qemu-s390x] " Collin L. Walling
2018-01-26 9:50 ` Thomas Huth [this message]
2018-01-23 18:26 ` [Qemu-devel] [PATCH v4 08/10] s390-ccw: print zipl boot menu Collin L. Walling
2018-01-25 15:46 ` Thomas Huth
2018-01-29 10:15 ` [Qemu-devel] [qemu-s390x] " David Hildenbrand
2018-01-29 14:27 ` Collin L. Walling
2018-01-23 18:26 ` [Qemu-devel] [PATCH v4 09/10] s390-ccw: read user input for boot index via the SCLP console Collin L. Walling
2018-01-26 10:44 ` Thomas Huth
2018-01-29 10:07 ` [Qemu-devel] [qemu-s390x] " David Hildenbrand
2018-01-29 10:11 ` David Hildenbrand
2018-01-29 15:16 ` Collin L. Walling
2018-01-29 13:08 ` David Hildenbrand
2018-01-29 14:38 ` Collin L. Walling
2018-01-29 15:17 ` David Hildenbrand
2018-01-23 18:26 ` [Qemu-devel] [PATCH v4 10/10] s390-ccw: interactive boot menu for scsi Collin L. Walling
2018-01-23 19:18 ` [Qemu-devel] [PATCH v4 00/10] Interactive Boot Menu for DASD and SCSI Guests on s390x Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fb0b863-0b5b-120e-7f19-093ecdb3a93c@redhat.com \
--to=thuth@redhat.com \
--cc=alifm@linux.vnet.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=walling@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).