From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
Alistair Francis <alistair.francis@wdc.com>,
David Gibson <david@gibson.dropbear.id.au>,
qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [PATCH] meson.build: Use a function from libfdt 1.5.1 for the library check
Date: Wed, 19 Jan 2022 09:49:25 +0100 [thread overview]
Message-ID: <1fb12907-943e-1039-3916-5e5e1ec80075@redhat.com> (raw)
In-Reply-To: <20220118170548.97288-1-thuth@redhat.com>
On 1/18/22 18:05, Thomas Huth wrote:
> The fdt version test in meson.build uses a function from libfdt v1.4.7,
> but we require version 1.5.1 nowadays. Thus use a function that has
> been introduced in that version instead.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/822
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 762d7cee85..d1cc04c7a2 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2276,7 +2276,7 @@ if have_system
> if fdt.found() and cc.links('''
> #include <libfdt.h>
> #include <libfdt_env.h>
> - int main(void) { fdt_check_full(NULL, 0); return 0; }''',
> + int main(void) { fdt_find_max_phandle(NULL, NULL); return 0; }''',
> dependencies: fdt)
> fdt_opt = 'system'
> elif fdt_opt == 'system'
Queued, thanks.
Paolo
prev parent reply other threads:[~2022-01-19 9:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 17:05 [PATCH] meson.build: Use a function from libfdt 1.5.1 for the library check Thomas Huth
2022-01-18 17:52 ` Philippe Mathieu-Daudé via
2022-01-18 22:34 ` Alistair Francis
2022-01-18 23:27 ` David Gibson
2022-01-19 8:49 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fb12907-943e-1039-3916-5e5e1ec80075@redhat.com \
--to=pbonzini@redhat.com \
--cc=alistair.francis@wdc.com \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).