From: Eric Blake <eblake@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Jeff Cody <jcody@redhat.com>,
Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/4] block/gluster: cleanups for GlfsPreopened
Date: Fri, 27 Jan 2017 08:23:40 -0600 [thread overview]
Message-ID: <1fb695b9-1ac2-964f-984c-c32f04ae5e90@redhat.com> (raw)
In-Reply-To: <20170127100029.11356-1-stefanha@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 999 bytes --]
On 01/27/2017 04:00 AM, Stefan Hajnoczi wrote:
> Code added in commit 6349c15410361d3fe52c9beee309954d606f8ccd ("block/gluster:
> memory usage: use one glfs instance per volume") does not follow conventions
> and violates QEMU coding style. Although any single issue in isolation is not
> worth patching, there are several of these and I think it's worth resolving
> them together in one sweep.
>
> Stefan Hajnoczi (4):
> block/gluster: fix wrong indent in glfs_find_preopened()
> block/gluster: drop intermediate ListElement struct
> block/gluster: use conventional names for GlfsPreopened functions
> block/gluster: add missing QLIST_HEAD_INITIALIZER()
For the series,
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> block/gluster.c | 66 +++++++++++++++++++++++++++------------------------------
> 1 file changed, 31 insertions(+), 35 deletions(-)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2017-01-27 14:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 10:00 [Qemu-devel] [PATCH 0/4] block/gluster: cleanups for GlfsPreopened Stefan Hajnoczi
2017-01-27 10:00 ` [Qemu-devel] [PATCH 1/4] block/gluster: fix wrong indent in glfs_find_preopened() Stefan Hajnoczi
2017-01-27 10:00 ` [Qemu-devel] [PATCH 2/4] block/gluster: drop intermediate ListElement struct Stefan Hajnoczi
2017-01-27 10:00 ` [Qemu-devel] [PATCH 3/4] block/gluster: use conventional names for GlfsPreopened functions Stefan Hajnoczi
2017-01-27 10:00 ` [Qemu-devel] [PATCH 4/4] block/gluster: add missing QLIST_HEAD_INITIALIZER() Stefan Hajnoczi
2017-01-27 14:23 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fb695b9-1ac2-964f-984c-c32f04ae5e90@redhat.com \
--to=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=prasanna.kalever@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).