From: Eric Blake <eblake@redhat.com>
To: Michael Nawrocki <michael.nawrocki@gtri.gatech.edu>,
Peter Maydell <peter.maydell@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Qemu-block <qemu-block@nongnu.org>, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 1/3] Switch AMD CFI flash to use new MMIO API
Date: Tue, 28 Nov 2017 14:27:51 -0600 [thread overview]
Message-ID: <1fbc3c84-b197-7da0-b70d-a95952e87860@redhat.com> (raw)
In-Reply-To: <eb039f59-f43b-88c7-324e-31a336a8d433@redhat.com>
On 11/28/2017 02:05 PM, Eric Blake wrote:
> Better yet, please fix the PFLASH_DEBUG code to avoid bitrot in the
> first place, by rewriting the bad pattern:
>
> into the good pattern:
>
> #ifdef PFLASH_DEBUG
> # define PFLASH_PRINT 1
> #else
> # define PFLASH_PRINT 0
> #endif
> #define DPRINTF(fmt, ...) \
> do { \
> if (PFLASH_PRINT) { \
> fprintf(stderr, "PFLASH: " fmt, ## __VA_ARGS__); \
> }; \
Serves me right for typing this without testing; the extra ; is spurious.
By the way, this is one of the Bite-Sized Tasks that never seems to get
finished...
https://wiki.qemu.org/BiteSizedTasks#Bitrot_prevention
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2017-11-28 20:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 16:14 [Qemu-devel] [PATCH v3 0/3] Add 8-byte wide AMD flash support, partial interleaving Mike Nawrocki
2017-11-13 16:14 ` [Qemu-devel] [PATCH v3 1/3] Switch AMD CFI flash to use new MMIO API Mike Nawrocki
2017-11-23 11:26 ` Peter Maydell
2017-11-23 11:27 ` Peter Maydell
2017-11-28 19:47 ` Michael Nawrocki
2017-11-28 20:05 ` Eric Blake
2017-11-28 20:27 ` Eric Blake [this message]
2017-11-13 16:14 ` [Qemu-devel] [PATCH v3 2/3] Enable 8-byte wide access to AMD CFI devices Mike Nawrocki
2017-11-23 11:49 ` Peter Maydell
2017-11-28 19:47 ` Michael Nawrocki
2017-11-13 17:31 ` [Qemu-devel] [PATCH v3 3/3] Add partial flash interleaving " Mike Nawrocki
2017-11-23 13:46 ` Peter Maydell
2017-11-28 19:47 ` Michael Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fbc3c84-b197-7da0-b70d-a95952e87860@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=michael.nawrocki@gtri.gatech.edu \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).