From: Paolo Bonzini <pbonzini@redhat.com>
To: "Keqian Zhu" <zhukeqian1@huawei.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Andrew Jones <drjones@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
Peter Xu <peterx@redhat.com>,
qemu-arm@nongnu.org, wanghaibin.wang@huawei.com
Subject: Re: [PATCH v2] Docs/RCU: Correct sample code of qatomic_rcu_set
Date: Thu, 7 Jan 2021 19:14:00 +0100 [thread overview]
Message-ID: <1fc6cbdb-8ae1-efa9-d294-f8412a77c6ce@redhat.com> (raw)
In-Reply-To: <20210106071710.15836-1-zhukeqian1@huawei.com>
On 06/01/21 08:17, Keqian Zhu wrote:
> Correct sample code to avoid confusing readers.
>
> Signed-off-by: Keqian Zhu <zhukeqian1@huawei.com>
> Cc: qemu-trivial@nongnu.org
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> Reviewed-by: Peter Xu <peterx@redhat.com>
> ---
>
> v2:
> - Add Cc and R-b.
>
> ---
> docs/devel/rcu.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/devel/rcu.txt b/docs/devel/rcu.txt
> index cdf002edd8..2e6cc607a1 100644
> --- a/docs/devel/rcu.txt
> +++ b/docs/devel/rcu.txt
> @@ -392,7 +392,7 @@ Instead, we store the size of the array with the array itself:
>
> /* Removal phase. */
> old_array = global_array;
> - qatomic_rcu_set(&new_array->data, new_array);
> + qatomic_rcu_set(&global_array, new_array);
> synchronize_rcu();
>
> /* Reclamation phase. */
>
Queued, thanks.
Paolo
prev parent reply other threads:[~2021-01-07 18:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 7:17 [PATCH v2] Docs/RCU: Correct sample code of qatomic_rcu_set Keqian Zhu
2021-01-06 17:02 ` Stefan Hajnoczi
2021-01-07 18:14 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fc6cbdb-8ae1-efa9-d294-f8412a77c6ce@redhat.com \
--to=pbonzini@redhat.com \
--cc=drjones@redhat.com \
--cc=ehabkost@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wanghaibin.wang@huawei.com \
--cc=zhukeqian1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).