From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E15DC433DB for ; Thu, 7 Jan 2021 18:14:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 14E02233FD for ; Thu, 7 Jan 2021 18:14:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 14E02233FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33932 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kxZoA-000700-KY for qemu-devel@archiver.kernel.org; Thu, 07 Jan 2021 13:14:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47338) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxZnV-0006PI-Bm for qemu-devel@nongnu.org; Thu, 07 Jan 2021 13:14:09 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:20951) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kxZnT-0000gM-Dw for qemu-devel@nongnu.org; Thu, 07 Jan 2021 13:14:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610043246; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EevDkj3Eq5HGyjrzEGnkPKUnTQ5NdW9RJ/mZwCBu75Y=; b=VHnuf8xpX+gQoe4KSCS3PiBQmYJ1XuqJaZglLzfcwJ+oYl5KZ8/OB08n3yk/nOvAAny4m2 yCzCqhyb+384IThkskoYVbpCGqEfUufSdPFzjK1JdHjYr9O34tqofhaCXbK01ChTXoVHz2 ZtONlJ3eApbs7EWClfbWcy1rH6RGPgE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-384-11My_ayZNWyY5HkLBQzF0A-1; Thu, 07 Jan 2021 13:14:05 -0500 X-MC-Unique: 11My_ayZNWyY5HkLBQzF0A-1 Received: by mail-wr1-f71.google.com with SMTP id u29so2993591wru.6 for ; Thu, 07 Jan 2021 10:14:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EevDkj3Eq5HGyjrzEGnkPKUnTQ5NdW9RJ/mZwCBu75Y=; b=MR/vGh4VywWFL7fJccLusp7fmNVkpJwOLxQHp80vF4B2oVUmSt0NbcMTiB+j8Tnb68 xiYimOicFogJLGiv/efGxx5XBJmYiqkg6gDUCvepQfn2xrEojZjiWVsrKMc0Iai0s+Jg QlAu450t0CS8RlGgDbwslLxpHdn9BfdjjQXQxmWOyQzvZv5PYxSp/0ME8eYFVMg/M/0u Z+c27mOqH5mFu4rOxewc0dHcW+e6r7hWBXUkCtk0Rk2oYXYK6HpN42snsZN0LLvnYGxm +X5zGjq/VTRVvIEj6ooWJIIstxM8+fnzg7XG3YaU2oWeZ5nR3rLBZ7epwPKg3KRHH5Qw 08qg== X-Gm-Message-State: AOAM532S27nLscQqaWp47/F3c2BrvsJ4DIJrIlO4Tw70JGrjo52W1VjJ fLQ7lqroDjaWN8yCMgz+BABrSqo6bJ+w4ZmAi118ltgU7U3AG556VED877p+Wog8GrQRLwB1f5m o41xDiHoAc5N99x4= X-Received: by 2002:a05:600c:2158:: with SMTP id v24mr8820027wml.129.1610043243058; Thu, 07 Jan 2021 10:14:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJyhpi5EQI3kZgP/cpmJXqwFHJ3L6zWKQJljm7pzpymkuvBcgJozVZYoJQ4/jifD8uvWmmabeQ== X-Received: by 2002:a05:600c:2158:: with SMTP id v24mr8820009wml.129.1610043242830; Thu, 07 Jan 2021 10:14:02 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id j10sm9513535wmj.7.2021.01.07.10.14.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Jan 2021 10:14:01 -0800 (PST) Subject: Re: [PATCH v2] Docs/RCU: Correct sample code of qatomic_rcu_set To: Keqian Zhu , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Stefan Hajnoczi References: <20210106071710.15836-1-zhukeqian1@huawei.com> From: Paolo Bonzini Message-ID: <1fc6cbdb-8ae1-efa9-d294-f8412a77c6ce@redhat.com> Date: Thu, 7 Jan 2021 19:14:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20210106071710.15836-1-zhukeqian1@huawei.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -32 X-Spam_score: -3.3 X-Spam_bar: --- X-Spam_report: (-3.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.246, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.267, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Andrew Jones , Eduardo Habkost , qemu-trivial@nongnu.org, qemu-devel@nongnu.org, Peter Xu , qemu-arm@nongnu.org, wanghaibin.wang@huawei.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 06/01/21 08:17, Keqian Zhu wrote: > Correct sample code to avoid confusing readers. > > Signed-off-by: Keqian Zhu > Cc: qemu-trivial@nongnu.org > Reviewed-by: Paolo Bonzini > Reviewed-by: Peter Xu > --- > > v2: > - Add Cc and R-b. > > --- > docs/devel/rcu.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/devel/rcu.txt b/docs/devel/rcu.txt > index cdf002edd8..2e6cc607a1 100644 > --- a/docs/devel/rcu.txt > +++ b/docs/devel/rcu.txt > @@ -392,7 +392,7 @@ Instead, we store the size of the array with the array itself: > > /* Removal phase. */ > old_array = global_array; > - qatomic_rcu_set(&new_array->data, new_array); > + qatomic_rcu_set(&global_array, new_array); > synchronize_rcu(); > > /* Reclamation phase. */ > Queued, thanks. Paolo