From: Richard Henderson <richard.henderson@linaro.org>
To: Anton Johansson <anjo@rev.ng>, qemu-devel@nongnu.org
Cc: pierrick.bouvier@linaro.org, philmd@linaro.org,
alistair.francis@wdc.com, palmer@dabbelt.com
Subject: Re: [PATCH 2/5] hw/riscv: Replace target_ulong uses
Date: Wed, 15 Oct 2025 09:31:15 -0700 [thread overview]
Message-ID: <1fc99217-f1e3-4ad9-8f67-89ab47995c98@linaro.org> (raw)
In-Reply-To: <20251015-feature-single-binary-hw-v1-v1-2-8b416eda42cf@rev.ng>
On 10/15/25 06:27, Anton Johansson wrote:
> - mask = (1L << (TARGET_LONG_BITS - (va_len - 1))) - 1;
> + mask = (1L << (target_long_bits() - (va_len - 1))) - 1;
While you're at it, long, via 1L, is always wrong.
Here, use MAKE_64BIT_MASK.
r~
next prev parent reply other threads:[~2025-10-15 16:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 13:27 [PATCH 0/5] single-binary: Prepare hw/riscv for single compilation Anton Johansson via
2025-10-15 13:27 ` [PATCH 1/5] hw/riscv: Use generic hwaddr for firmware addressses Anton Johansson via
2025-10-15 14:21 ` Philippe Mathieu-Daudé
2025-10-23 17:14 ` Anton Johansson via
2025-10-23 17:55 ` Philippe Mathieu-Daudé
2025-10-27 12:11 ` Anton Johansson via
2025-10-15 13:27 ` [PATCH 2/5] hw/riscv: Replace target_ulong uses Anton Johansson via
2025-10-15 14:22 ` Philippe Mathieu-Daudé
2025-10-15 16:31 ` Richard Henderson [this message]
2025-10-15 16:50 ` Philippe Mathieu-Daudé
2025-10-15 13:27 ` [PATCH 3/5] hw/riscv: Widen OpenSBI dynamic info struct Anton Johansson via
2025-10-16 23:42 ` Alistair Francis
2025-10-15 13:27 ` [PATCH 4/5] target-info: Introduce runtime TARGET_PHYS_ADDR_SPACE_BITS Anton Johansson via
2025-10-15 14:32 ` Philippe Mathieu-Daudé
2025-10-17 16:11 ` Anton Johansson via
2025-10-17 18:47 ` Richard Henderson
2025-10-18 2:34 ` Bibo Mao
2025-10-15 13:27 ` [PATCH 5/5] hw/riscv: Use runtime target_phys_addr_space_bits() Anton Johansson via
2025-10-16 23:43 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fc99217-f1e3-4ad9-8f67-89ab47995c98@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=anjo@rev.ng \
--cc=palmer@dabbelt.com \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).