Re: [PATCH] mips: always include nanomips disassembler

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 10/1/23 09:49, Paolo Bonzini wrote:
> Since the nanomips disassembler is not C++ code anymore, it need not
> depend on link_language == cpp.  Always include it and remove the
> CONFIG_NANOMIPS_DIS symbol.
> 
> Cc: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   disas/meson.build     | 3 +--
>   include/exec/poison.h | 1 -
>   meson.build           | 7 +------
>   target/mips/cpu.c     | 2 --
>   4 files changed, 2 insertions(+), 11 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

> diff --git a/meson.build b/meson.build
> index 175517eafde8..bfb461d1efac 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2478,7 +2478,7 @@ disassemblers = {
>     'x86_64' : ['CONFIG_I386_DIS'],
>     'm68k' : ['CONFIG_M68K_DIS'],
>     'microblaze' : ['CONFIG_MICROBLAZE_DIS'],
> -  'mips' : ['CONFIG_MIPS_DIS'],
> +  'mips' : [ 'CONFIG_MIPS_DIS'],

Queue to mips-next (dropping this one-space change).

>     'nios2' : ['CONFIG_NIOS2_DIS'],
>     'or1k' : ['CONFIG_OPENRISC_DIS'],
>     'ppc' : ['CONFIG_PPC_DIS'],
> @@ -2490,11 +2490,6 @@ disassemblers = {
>     'xtensa' : ['CONFIG_XTENSA_DIS'],
>     'loongarch' : ['CONFIG_LOONGARCH_DIS'],
>   }