From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56125) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fe3mt-000721-52 for qemu-devel@nongnu.org; Fri, 13 Jul 2018 15:31:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fe3ms-0006H7-BC for qemu-devel@nongnu.org; Fri, 13 Jul 2018 15:31:31 -0400 References: <20180713191506.14484-1-mreitz@redhat.com> From: John Snow Message-ID: <1fcd2232-1e2a-f2a9-286d-c6cc6b3d6985@redhat.com> Date: Fri, 13 Jul 2018 15:31:22 -0400 MIME-Version: 1.0 In-Reply-To: <20180713191506.14484-1-mreitz@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] iotests: Disallow compat=0.10 in 223 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: Kevin Wolf , qemu-devel@nongnu.org On 07/13/2018 03:15 PM, Max Reitz wrote: > 223 tests persistent dirty bitmaps which are not supported in > compat=0.10, so that option is unsupported for this test. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/223 | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/qemu-iotests/223 b/tests/qemu-iotests/223 > index b63b7a4f9e..8b1859c2dd 100755 > --- a/tests/qemu-iotests/223 > +++ b/tests/qemu-iotests/223 > @@ -40,6 +40,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 > _supported_fmt qcow2 > _supported_proto file # uses NBD as well > _supported_os Linux > +# Persistent dirty bitmaps require compat=1.1 > +_unsupported_imgopts 'compat=0.10' > > function do_run_qemu() > { > Thanks for catching this :) Tested-by: John Snow Reviewed-by: John Snow