* [Qemu-devel] [PATCH] iotests: Disallow compat=0.10 in 223
@ 2018-07-13 19:15 Max Reitz
2018-07-13 19:31 ` John Snow
2018-07-23 13:57 ` Kevin Wolf
0 siblings, 2 replies; 3+ messages in thread
From: Max Reitz @ 2018-07-13 19:15 UTC (permalink / raw)
To: qemu-block; +Cc: qemu-devel, Max Reitz, Kevin Wolf, John Snow
223 tests persistent dirty bitmaps which are not supported in
compat=0.10, so that option is unsupported for this test.
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
tests/qemu-iotests/223 | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/qemu-iotests/223 b/tests/qemu-iotests/223
index b63b7a4f9e..8b1859c2dd 100755
--- a/tests/qemu-iotests/223
+++ b/tests/qemu-iotests/223
@@ -40,6 +40,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
_supported_fmt qcow2
_supported_proto file # uses NBD as well
_supported_os Linux
+# Persistent dirty bitmaps require compat=1.1
+_unsupported_imgopts 'compat=0.10'
function do_run_qemu()
{
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] iotests: Disallow compat=0.10 in 223
2018-07-13 19:15 [Qemu-devel] [PATCH] iotests: Disallow compat=0.10 in 223 Max Reitz
@ 2018-07-13 19:31 ` John Snow
2018-07-23 13:57 ` Kevin Wolf
1 sibling, 0 replies; 3+ messages in thread
From: John Snow @ 2018-07-13 19:31 UTC (permalink / raw)
To: Max Reitz, qemu-block; +Cc: Kevin Wolf, qemu-devel
On 07/13/2018 03:15 PM, Max Reitz wrote:
> 223 tests persistent dirty bitmaps which are not supported in
> compat=0.10, so that option is unsupported for this test.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/qemu-iotests/223 | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/qemu-iotests/223 b/tests/qemu-iotests/223
> index b63b7a4f9e..8b1859c2dd 100755
> --- a/tests/qemu-iotests/223
> +++ b/tests/qemu-iotests/223
> @@ -40,6 +40,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
> _supported_fmt qcow2
> _supported_proto file # uses NBD as well
> _supported_os Linux
> +# Persistent dirty bitmaps require compat=1.1
> +_unsupported_imgopts 'compat=0.10'
>
> function do_run_qemu()
> {
>
Thanks for catching this :)
Tested-by: John Snow <jsnow@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] iotests: Disallow compat=0.10 in 223
2018-07-13 19:15 [Qemu-devel] [PATCH] iotests: Disallow compat=0.10 in 223 Max Reitz
2018-07-13 19:31 ` John Snow
@ 2018-07-23 13:57 ` Kevin Wolf
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Wolf @ 2018-07-23 13:57 UTC (permalink / raw)
To: Max Reitz; +Cc: qemu-block, qemu-devel, John Snow
Am 13.07.2018 um 21:15 hat Max Reitz geschrieben:
> 223 tests persistent dirty bitmaps which are not supported in
> compat=0.10, so that option is unsupported for this test.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-23 13:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-13 19:15 [Qemu-devel] [PATCH] iotests: Disallow compat=0.10 in 223 Max Reitz
2018-07-13 19:31 ` John Snow
2018-07-23 13:57 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).