From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24596C3ABD8 for ; Fri, 16 May 2025 18:15:48 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uFza8-0006rl-KZ; Fri, 16 May 2025 14:14:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uFza6-0006rK-Pj for qemu-devel@nongnu.org; Fri, 16 May 2025 14:14:50 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uFza4-0002Kk-NB for qemu-devel@nongnu.org; Fri, 16 May 2025 14:14:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747419286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=bcKdV9n08KuIhW8Ntk5hR7NRO88esUhieiAsU9zhQCI=; b=KV4mvvh5y9k4l1s7bXTqA3rvmHwZ7Yc9BDW30FI37VKnSpuqTnuAqfZvDb2M5wxskExJpy CK8g5CHOPqLZo2LDqSdfSIktoCai60GROxeWpsBr7beBFmv/tI1fXGH85KdFZblcwR/kVu eW5JNZtDx6JIeDG/Wniwk4LHy28qdxw= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-533-PPZTNotYNMiXVYj4Da9cmg-1; Fri, 16 May 2025 14:14:45 -0400 X-MC-Unique: PPZTNotYNMiXVYj4Da9cmg-1 X-Mimecast-MFC-AGG-ID: PPZTNotYNMiXVYj4Da9cmg_1747419284 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-442ffaa7dbeso7109155e9.3 for ; Fri, 16 May 2025 11:14:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747419284; x=1748024084; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bcKdV9n08KuIhW8Ntk5hR7NRO88esUhieiAsU9zhQCI=; b=JahpVPrlhlgSytU8ABoc+ODoXvxrPcXHcNFEGAqcIRA1naVl8MwYuBIuFad51cIAqh dFeh26bXkDir4V0ZZK2+DRlp2SK9b4U5N6cOOPuL30TzBmDO9NukDVCaIFjkBMOcDeK/ TEYmLSrb/TCSFNA5pa/DooKlbXjCUS2c/Vc2sdOe869wIkJTzYl8uw16y6h/fRr+dMfU X/ScYkB8NdpD3gPn2aWgLTttgWqCJn918wl38Bm6ohvOe9AgAiH1PuL6IfTn8B1b1b4r +c3877c4zUVcoUsVUrLD6csM8O1QYWHojBg5dvDi/DBJWjG1XEpx88va2EC1Ko9X3KDN DsEA== X-Forwarded-Encrypted: i=1; AJvYcCXyS7BtStiOrTv4+xhvS7npY/wnJjQFHv65FKwF0MrVi20ZObrrtKZTtN7e3Sb4fg7oClTy24THMKnO@nongnu.org X-Gm-Message-State: AOJu0YyK9yF8Sr2pOy7/Q2bF88dJBkOt5hvgzb19AakJm+GmynpSauwc 3RbtNKAsVk6k4DsjmfHvY8xmnTZa94+PVRutI7KkNXgB5ivWsea+G4YuuRwcDOFInV/TRwpSmPg dvHiJkwD1tdOduapu4ifPWYV2Pk9MUCPYWxtz76+o1jLCK4F5AnZxU+2G X-Gm-Gg: ASbGnctQVQatRZqWJpWLT9xqabea3VZ+CUBAbliJDUfM2Zg7IRfd0VdQPWQUz/Kd6Zj uWGNZGammZtgwfZJW2+K9fkef7pjUSq3XzILpFzHZ7D9TSF4I8yXPNPqv80nDplXKIFLGmsaLXh 2XtCHQX8mX/0BWB03cdYC9lfmWQFtFmmrOm/7itRI4LG8l/Qsnot1gq9bvEEvhxJT+JPA9e9f1s P+ootH/m63IpokBpJ8aKUGV0KsZQKh3fwjxBCiMBMKbFHzqydEVkbZLdM9r8bS5q1/gQZ1fnWNG NEfN/j7KGtsPInOSd3ff/fC34ym7QmwFeXRUuYnboeo= X-Received: by 2002:a05:600c:3554:b0:43c:fda5:41e9 with SMTP id 5b1f17b1804b1-442fd672521mr50620355e9.31.1747419284006; Fri, 16 May 2025 11:14:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFGlVBp1WK6LwG22ji6Ms/NiffjkHJdtk/nFdAqXpBavOnilNjb+ejWzDPYirtXjtbcQrfMFA== X-Received: by 2002:a05:600c:3554:b0:43c:fda5:41e9 with SMTP id 5b1f17b1804b1-442fd672521mr50620165e9.31.1747419283647; Fri, 16 May 2025 11:14:43 -0700 (PDT) Received: from [192.168.0.7] (ip-109-42-48-129.web.vodafone.de. [109.42.48.129]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442f3380498sm118788015e9.11.2025.05.16.11.14.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 May 2025 11:14:43 -0700 (PDT) Message-ID: <1fd458bd-f390-4d4b-acde-465f28e0dea8@redhat.com> Date: Fri, 16 May 2025 20:14:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 0/2] GT64120 PCI endianness fixes and cleanup To: Rakesh Jeyasingh , qemu-devel@nongnu.org, philmd@linaro.org Cc: pbonzini@redhat.com, balaton@eik.bme.hu References: <20250429170354.150581-1-rakeshjb010@gmail.com> Content-Language: en-US From: Thomas Huth Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20250429170354.150581-1-rakeshjb010@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -37 X-Spam_score: -3.8 X-Spam_bar: --- X-Spam_report: (-3.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.686, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 29/04/2025 19.03, Rakesh Jeyasingh wrote: > Changes since v4: > 1.Introduced needs_bswap() helper for clean endianness logic > 2.use the existing pci_host_data_le_ops.read/write from hw/pci/pci_host.c > > v4:https://patchew.org/QEMU/20250331184820.34673-1-rakeshjb010@gmail.com/ > > Rakesh Jeyasingh (2): > hw/pci-host/gt64120: Fix endianness handling > hw/pci-host: Remove unused pci_host_data_be_ops > > hw/pci-host/gt64120.c | 82 ++++++++++++++++++++++---------------- > hw/pci/pci_host.c | 6 --- > include/hw/pci-host/dino.h | 4 -- > include/hw/pci/pci_host.h | 1 - > 4 files changed, 48 insertions(+), 45 deletions(-) Thanks for tackling this ... I gave it a try on both, little and big endian host and it seems to work as expected now. Series Tested-by: Thomas Huth