From: Max Reitz <mreitz@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 0/2] block: Use bdrv_unref_child() for all children in bdrv_close()
Date: Mon, 13 May 2019 16:32:04 +0200 [thread overview]
Message-ID: <1fe2bae0-2988-bc50-9827-1f6382223538@redhat.com> (raw)
In-Reply-To: <cover.1557754872.git.berto@igalia.com>
[-- Attachment #1: Type: text/plain, Size: 1056 bytes --]
On 13.05.19 15:46, Alberto Garcia wrote:
> Hi,
>
> the first patch is the same as in v2 (with an updated commit
> message). The second patch is new and makes bdrv_root_attach_child()
> unref child_bs on failure, as suggested by Max.
>
> Regards,
>
> Berto
>
> v2: https://lists.gnu.org/archive/html/qemu-block/2019-05/msg00325.html
> v1: https://lists.gnu.org/archive/html/qemu-block/2019-03/msg01040.html
>
> Alberto Garcia (2):
> block: Use bdrv_unref_child() for all children in bdrv_close()
> block: Make bdrv_root_attach_child() unref child_bs on failure
>
> block.c | 41 ++++++++++++++++++++---------------------
> block/block-backend.c | 3 +--
> block/quorum.c | 1 -
> blockjob.c | 2 +-
> tests/test-bdrv-drain.c | 6 ------
> tests/test-bdrv-graph-mod.c | 1 -
> 6 files changed, 22 insertions(+), 32 deletions(-)
Thanks for bearing with me, applied to my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-05-13 14:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 13:46 [Qemu-devel] [PATCH v3 0/2] block: Use bdrv_unref_child() for all children in bdrv_close() Alberto Garcia
2019-05-13 13:46 ` [Qemu-devel] [PATCH v3 1/2] " Alberto Garcia
2019-05-23 15:27 ` Alberto Garcia
2019-05-23 15:57 ` Max Reitz
2019-05-13 13:46 ` [Qemu-devel] [PATCH v3 2/2] block: Make bdrv_root_attach_child() unref child_bs on failure Alberto Garcia
2019-05-13 14:31 ` Max Reitz
2019-05-13 15:52 ` Alberto Garcia
2019-05-13 15:54 ` Max Reitz
2019-05-13 14:32 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fe2bae0-2988-bc50-9827-1f6382223538@redhat.com \
--to=mreitz@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).