From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 958C9C04AA7 for ; Mon, 13 May 2019 14:34:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A2A0208C3 for ; Mon, 13 May 2019 14:34:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A2A0208C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:58430 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQC1l-0003oq-KT for qemu-devel@archiver.kernel.org; Mon, 13 May 2019 10:34:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40788) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQBzv-0002w8-Rv for qemu-devel@nongnu.org; Mon, 13 May 2019 10:32:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQBzu-0001R2-QL for qemu-devel@nongnu.org; Mon, 13 May 2019 10:32:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58760) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hQBzs-0001Pt-5f; Mon, 13 May 2019 10:32:08 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8005F3086216; Mon, 13 May 2019 14:32:07 +0000 (UTC) Received: from dresden.str.redhat.com (unknown [10.40.206.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2BEC51001DE1; Mon, 13 May 2019 14:32:05 +0000 (UTC) To: Alberto Garcia , qemu-devel@nongnu.org References: From: Max Reitz Openpgp: preference=signencrypt Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: <1fe2bae0-2988-bc50-9827-1f6382223538@redhat.com> Date: Mon, 13 May 2019 16:32:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="85I136OkW4c0GCSmTdFxRb967j6UVVSa0" X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Mon, 13 May 2019 14:32:07 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [Qemu-devel] [PATCH v3 0/2] block: Use bdrv_unref_child() for all children in bdrv_close() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --85I136OkW4c0GCSmTdFxRb967j6UVVSa0 From: Max Reitz To: Alberto Garcia , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Kevin Wolf Message-ID: <1fe2bae0-2988-bc50-9827-1f6382223538@redhat.com> Subject: Re: [PATCH v3 0/2] block: Use bdrv_unref_child() for all children in bdrv_close() References: In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 13.05.19 15:46, Alberto Garcia wrote: > Hi, >=20 > the first patch is the same as in v2 (with an updated commit > message). The second patch is new and makes bdrv_root_attach_child() > unref child_bs on failure, as suggested by Max. >=20 > Regards, >=20 > Berto >=20 > v2: https://lists.gnu.org/archive/html/qemu-block/2019-05/msg00325.html= > v1: https://lists.gnu.org/archive/html/qemu-block/2019-03/msg01040.html= >=20 > Alberto Garcia (2): > block: Use bdrv_unref_child() for all children in bdrv_close() > block: Make bdrv_root_attach_child() unref child_bs on failure >=20 > block.c | 41 ++++++++++++++++++++-----------------= ---- > block/block-backend.c | 3 +-- > block/quorum.c | 1 - > blockjob.c | 2 +- > tests/test-bdrv-drain.c | 6 ------ > tests/test-bdrv-graph-mod.c | 1 - > 6 files changed, 22 insertions(+), 32 deletions(-) Thanks for bearing with me, applied to my block branch: https://git.xanclic.moe/XanClic/qemu/commits/branch/block Max --85I136OkW4c0GCSmTdFxRb967j6UVVSa0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAlzZf+QACgkQ9AfbAGHV z0AHAgf/c2V371sQQrdv7HV5lRmeJhvxqUw3zX+GYLaQ293k3/JK4qC5owUPOnwG rIMVm8wx6mYuXJqH1zgG8YSyk6DXOYACUwvXkmfyeE04OnX+APynP2mDCeVqpACX hP1PZCUheIdQ+7g2VN74voSL57TMRaVnMRTNj/bAycox7NGnMNahS4wodm/B0JhH I06Gf3oSdWVQ37Z69eO7+TplwZiv2aSIzboW5Ri7AN4MEsileuzUH/A9I7IxIFcP OO1UUHBgREuoabS6rmXoXo4rwnJd6uSVa/HRonjvS5uDTcrn5GcakUUk2wisXLp5 sjCMnBZM1jy1Fsdj7rPiLLywoyxbdg== =RWIw -----END PGP SIGNATURE----- --85I136OkW4c0GCSmTdFxRb967j6UVVSa0--