From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45335)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1bF2k2-00015t-Fq
	for qemu-devel@nongnu.org; Mon, 20 Jun 2016 13:12:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1bF2k0-0005Ow-KV
	for qemu-devel@nongnu.org; Mon, 20 Jun 2016 13:12:05 -0400
References: <cover.1465459496.git.berto@igalia.com>
	<8f88c9e65e3ac4f473efa4195f0996cf8c728bf9.1465459496.git.berto@igalia.com>
From: Max Reitz <mreitz@redhat.com>
Message-ID: <1fe60637-3ae2-3901-f7ab-8dd0daa3a661@redhat.com>
Date: Mon, 20 Jun 2016 19:11:55 +0200
MIME-Version: 1.0
In-Reply-To: <8f88c9e65e3ac4f473efa4195f0996cf8c728bf9.1465459496.git.berto@igalia.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="UO2I5dgmovVErUDI216PHq1gr5XhIs6Da"
Subject: Re: [Qemu-devel] [PATCH 05/15] blockjob: Add 'job_id' parameter to
 block_job_create()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>, Eric Blake <eblake@redhat.com>, Jeff Cody <jcody@redhat.com>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--UO2I5dgmovVErUDI216PHq1gr5XhIs6Da
From: Max Reitz <mreitz@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
 Eric Blake <eblake@redhat.com>, Jeff Cody <jcody@redhat.com>
Message-ID: <1fe60637-3ae2-3901-f7ab-8dd0daa3a661@redhat.com>
Subject: Re: [PATCH 05/15] blockjob: Add 'job_id' parameter to
 block_job_create()
References: <cover.1465459496.git.berto@igalia.com>
 <8f88c9e65e3ac4f473efa4195f0996cf8c728bf9.1465459496.git.berto@igalia.com>
In-Reply-To: <8f88c9e65e3ac4f473efa4195f0996cf8c728bf9.1465459496.git.berto@igalia.com>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: quoted-printable

On 09.06.2016 10:20, Alberto Garcia wrote:
> Job IDs are generated automatically when a new job is created. This
> patch adds a new 'job_id' parameter to let the caller provide one
> instead. In this case the ID is verified to be unique and well-formed.
>=20
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
>  block/backup.c            |  3 ++-
>  block/commit.c            |  2 +-
>  block/mirror.c            |  2 +-
>  block/stream.c            |  2 +-
>  blockjob.c                | 19 +++++++++++++++----
>  include/block/blockjob.h  |  8 +++++---
>  tests/test-blockjob-txn.c |  2 +-
>  7 files changed, 26 insertions(+), 12 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>


--UO2I5dgmovVErUDI216PHq1gr5XhIs6Da
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJXaCPcAAoJEDuxQgLoOKytZlkH/1WNBxLcpsKsHpjOE64VXTLu
x96nKaYjFmJkidPnUK1Ia73Ha1vCKw4oOgUWjYvUeprvv9A3x8lKnxTvYG+5f9iy
K1K4Oa3ersWwVy0DrS1sk87HRf8sLAz/ubEvBBGPxq7EAuEpctq2o1giNEER0wUQ
tTd6q44gTvXkV81TNVResU86Y+DzO22sVSgebcOKHG+TKJLeP5xaKpCFS0wv+U1R
zEXEveah4lgTdTl4EMtHjqL0JXLSfcT7sF1LngFvDAByS/oTaP5RrZgP9PT/qXnJ
KYx828fvpgS48to6FV8xRrKH/qRrJ1EeMvETwP4DB9Alx4qdzn8nM24GCL/mWw8=
=16Ln
-----END PGP SIGNATURE-----

--UO2I5dgmovVErUDI216PHq1gr5XhIs6Da--