From: Thomas Huth <thuth@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Elena Ufimtseva <elena.ufimtseva@oracle.com>,
John G Johnson <john.g.johnson@oracle.com>,
Jagannathan Raman <jag.raman@oracle.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
John Snow <jsnow@redhat.com>
Subject: Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine
Date: Wed, 28 Apr 2021 11:32:49 +0200 [thread overview]
Message-ID: <1fea2e39-c1c7-215f-843e-fc593ff7f47c@redhat.com> (raw)
In-Reply-To: <YIkpzdUkgHs4vYCe@stefanha-x1.localdomain>
On 28/04/2021 11.24, Stefan Hajnoczi wrote:
> On Fri, Apr 16, 2021 at 02:52:56PM +0200, Thomas Huth wrote:
>> @@ -158,7 +166,11 @@ static void pci_piix_ide_realize(PCIDevice *dev, Error **errp)
>>
>> vmstate_register(VMSTATE_IF(dev), 0, &vmstate_ide_pci, d);
>>
>> - pci_piix_init_ports(d);
>> + rc = pci_piix_init_ports(d);
>> + if (rc) {
>> + error_setg_errno(errp, -rc, "Failed to realize %s",
>> + object_get_typename(OBJECT(dev)));
>> + }
>
> Is there an error message explaining the reason for the failure
> somewhere. I can't see one in the patch and imagine users will be
> puzzled/frustrated by a generic "Failed to realize" error message. Can
> you make it more meaningful?
Do you have a suggestion for a better message?
Thomas
next prev parent reply other threads:[~2021-04-28 9:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 12:52 [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine Thomas Huth
2021-04-27 13:27 ` Philippe Mathieu-Daudé
2021-04-27 13:54 ` Stefan Hajnoczi
2021-04-27 17:16 ` John Snow
2021-04-27 17:54 ` Philippe Mathieu-Daudé
2021-04-27 18:02 ` John Snow
2021-04-28 9:22 ` Stefan Hajnoczi
2021-04-28 14:18 ` Markus Armbruster
2021-04-28 18:43 ` Stefan Hajnoczi
2021-04-29 6:08 ` Markus Armbruster
2021-05-03 17:53 ` Philippe Mathieu-Daudé
2021-04-28 9:15 ` Stefan Hajnoczi
2021-04-28 14:21 ` Markus Armbruster
2021-04-27 18:06 ` John Snow
2021-04-28 9:24 ` Stefan Hajnoczi
2021-04-28 9:32 ` Thomas Huth [this message]
2021-04-28 10:53 ` Philippe Mathieu-Daudé
2021-05-18 19:21 ` John Snow
2021-05-18 21:07 ` John Snow
2021-07-06 8:24 ` Thomas Huth
2021-07-06 8:37 ` Philippe Mathieu-Daudé
2021-07-07 9:30 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fea2e39-c1c7-215f-843e-fc593ff7f47c@redhat.com \
--to=thuth@redhat.com \
--cc=elena.ufimtseva@oracle.com \
--cc=jag.raman@oracle.com \
--cc=john.g.johnson@oracle.com \
--cc=jsnow@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).