From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56044C433B4 for ; Wed, 28 Apr 2021 09:34:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9FC576141E for ; Wed, 28 Apr 2021 09:34:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9FC576141E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52720 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbgaZ-0001x3-Cm for qemu-devel@archiver.kernel.org; Wed, 28 Apr 2021 05:34:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42724) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbgZ2-0001PH-8O for qemu-devel@nongnu.org; Wed, 28 Apr 2021 05:33:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:42025) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbgYx-0002fM-TK for qemu-devel@nongnu.org; Wed, 28 Apr 2021 05:32:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619602375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EGWaJrcMiHs5cYsCEDV6Ych53V8aZClsOUvxyZU99Lo=; b=MgZ/W/OHYf1viITi4inVSleuQNq4YOl/8y51/FFz+f+68a5tWLwgoI6BJOdGJZ/FuuQKlO ewmnWw/vgq/LLzS9nf32pNdi6gn4d5YO/HdFpFIJ/Y1a4bntHouSU9wAmU5Xs6E+mpCJeK 9xwGx3//YGsSjxpeFxWn9WKxmsJkujU= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-473-JCvO0ur2PAagGPCZlyNqGQ-1; Wed, 28 Apr 2021 05:32:52 -0400 X-MC-Unique: JCvO0ur2PAagGPCZlyNqGQ-1 Received: by mail-wr1-f70.google.com with SMTP id 65-20020adf82c70000b0290107593a42c3so10500658wrc.5 for ; Wed, 28 Apr 2021 02:32:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EGWaJrcMiHs5cYsCEDV6Ych53V8aZClsOUvxyZU99Lo=; b=A7xci4FzCAXpsRsOQS24urTactWX5L1yo8Ln3A2LwyfvI7AZoWhirZatrjoL2tJjb1 GSizyQinAnWf0eNPmT9qP16My6rkUT3MPzr6OAgkMAOwUz1/hS67DR6LdhQaYVC73eU2 IlNOQavmgoX/ALE/84C3UKqNDwtYVYmmKE2mwMh9IzufwOZa4LxmqWNk7j+Xz2hCYKot 9EucUJFoq08tQGzRj/JBwq6L9XhEIbQ6lq61vqreZWAYyQGLLdBSQIQUTx06VVsIU8/7 smFpuHeYqgeSsJPNvVVRK1UMO8q/iXs4pz0IPpRJkcQ4aGNwueEGyZhiQaHtZoWpRTQf 4/1Q== X-Gm-Message-State: AOAM530tCSOb2lXQ4LnOGGyXS351qfkcRLxLTI1iOi3cVtG4az5Kxc8m 02k0BeCrDgeguvODi9PWMhVt+MXVpFHRMBsEzjiG864o3SxDeFOB/zjpdyxLgtY2Q/ciy0KhS16 Ea8CbZSHfjtR95Pk= X-Received: by 2002:a1c:e409:: with SMTP id b9mr3411320wmh.189.1619602371619; Wed, 28 Apr 2021 02:32:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJymQAsgfJwLIF7x77K+RVgshw4bhTQhqqe1Fldj6jSM81eJYrMscHyPzJ0XyNFdVF4fOOAL3Q== X-Received: by 2002:a1c:e409:: with SMTP id b9mr3411286wmh.189.1619602371364; Wed, 28 Apr 2021 02:32:51 -0700 (PDT) Received: from thuth.remote.csb (pd9e839c7.dip0.t-ipconnect.de. [217.232.57.199]) by smtp.gmail.com with ESMTPSA id g19sm3018639wme.48.2021.04.28.02.32.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Apr 2021 02:32:50 -0700 (PDT) Subject: Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine To: Stefan Hajnoczi References: <20210416125256.2039734-1-thuth@redhat.com> From: Thomas Huth Message-ID: <1fea2e39-c1c7-215f-843e-fc593ff7f47c@redhat.com> Date: Wed, 28 Apr 2021 11:32:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.218, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Elena Ufimtseva , John G Johnson , Jagannathan Raman , qemu-block@nongnu.org, qemu-devel@nongnu.org, John Snow Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 28/04/2021 11.24, Stefan Hajnoczi wrote: > On Fri, Apr 16, 2021 at 02:52:56PM +0200, Thomas Huth wrote: >> @@ -158,7 +166,11 @@ static void pci_piix_ide_realize(PCIDevice *dev, Error **errp) >> >> vmstate_register(VMSTATE_IF(dev), 0, &vmstate_ide_pci, d); >> >> - pci_piix_init_ports(d); >> + rc = pci_piix_init_ports(d); >> + if (rc) { >> + error_setg_errno(errp, -rc, "Failed to realize %s", >> + object_get_typename(OBJECT(dev))); >> + } > > Is there an error message explaining the reason for the failure > somewhere. I can't see one in the patch and imagine users will be > puzzled/frustrated by a generic "Failed to realize" error message. Can > you make it more meaningful? Do you have a suggestion for a better message? Thomas