qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Roman Bolshakov <r.bolshakov@yadro.com>, qemu-devel@nongnu.org
Cc: "QEMU Trivial" <qemu-trivial@nongnu.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH v2 2/4] Makefile: Require GNU make 3.82+
Date: Mon, 12 Oct 2020 11:47:16 +0200	[thread overview]
Message-ID: <1ff85cc3-40dc-98da-fb18-a1b3d134d7dc@redhat.com> (raw)
In-Reply-To: <20200825202755.50626-3-r.bolshakov@yadro.com>

On 25/08/2020 22.27, Roman Bolshakov wrote:
> QEMU build fails with cryptic messages if make is too old:
> 
>   Makefile.ninja:2655: *** multiple target patterns.  Stop.
> 
> To avoid the confusion it's worth to fail the build right away and print
> a friendly error message.
> 
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
> ---
>  Makefile | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index 81794d5c34..b4ebf3e30f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -4,6 +4,11 @@ ifneq ($(words $(subst :, ,$(CURDIR))), 1)
>    $(error main directory cannot contain spaces nor colons)
>  endif
>  
> +ifeq ($(filter undefine,$(value .FEATURES)),)
> +$(error Unsupported Make version: $(MAKE_VERSION). \
> +        Please use GNU Make 3.82 or above)
> +endif
> +
>  # Always point to the root of the build tree (needs GNU make).
>  BUILD_DIR=$(CURDIR)

Reviewed-by: Thomas Huth <thuth@redhat.com>



  reply	other threads:[~2020-10-12  9:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-25 20:27 [PATCH v2 0/4] Compatibility make fixes for meson Roman Bolshakov
2020-08-25 20:27 ` [PATCH v2 1/4] configure: Use discovered make for in-source build Roman Bolshakov
2020-08-25 20:27 ` [PATCH v2 2/4] Makefile: Require GNU make 3.82+ Roman Bolshakov
2020-10-12  9:47   ` Thomas Huth [this message]
2020-12-13 17:21     ` Laurent Vivier
2020-12-13 19:04       ` Peter Maydell
2020-12-13 22:56         ` Laurent Vivier
2020-12-14 13:46           ` Roman Bolshakov
2020-08-25 20:27 ` [PATCH v2 3/4] configure: Prefer gmake on darwin Roman Bolshakov
2020-08-25 20:27 ` [PATCH v2 4/4] configure: Test if $make actually exists Roman Bolshakov
2020-10-12  9:49   ` Thomas Huth
2020-12-13 17:22     ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ff85cc3-40dc-98da-fb18-a1b3d134d7dc@redhat.com \
    --to=thuth@redhat.com \
    --cc=berrange@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=r.bolshakov@yadro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).