From: Rusty Russell <rusty@rustcorp.com.au>
To: Fabrice Bellard <fabrice.bellard@free.fr>
Cc: cyeoh@samba.org, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] fixed stat64 support (take II)
Date: Wed, 23 Apr 2003 18:15:45 +1000 [thread overview]
Message-ID: <20030423081611.DF33C2C0A5@lists.samba.org> (raw)
Previous version of this patch added packed attribute, but didn't fix
st_ino. Chris's glibc version found this one, too.
Name: Fix stat64
Author: Rusty Russell
Status: Tested
D: PPC64 gets size of x86 stat64 struct wrong due to padding
D: differences. Also, translation of st_ino is incorrect.
diff -urpN --exclude TAGS -X /home/rusty/current-dontdiff --minimal qemu-0.1.6/syscall-i386.h qemu-0.1.6-debug/syscall-i386.h
--- qemu-0.1.6/syscall-i386.h 2003-04-11 11:01:57.000000000 +1000
+++ qemu-0.1.6-debug/syscall-i386.h 2003-04-23 17:39:27.000000000 +1000
@@ -330,7 +329,7 @@ struct target_stat64 {
target_ulong __pad7; /* will be high 32 bits of ctime someday */
unsigned long long st_ino;
-};
+} __attribute__((packed));
#define TARGET_SA_NOCLDSTOP 0x00000001
#define TARGET_SA_NOCLDWAIT 0x00000002 /* not supported yet */
diff -urpN --exclude TAGS -X /home/rusty/current-dontdiff --minimal qemu-0.1.6/syscall.c qemu-0.1.6-debug/syscall.c
--- qemu-0.1.6/syscall.c 2003-04-11 11:01:57.000000000 +1000
+++ qemu-0.1.6-debug/syscall.c 2003-04-23 17:41:01.000000000 +1000
@@ -2257,7 +2257,7 @@ long do_syscall(void *cpu_env, int num,
struct target_stat64 *target_st = (void *)arg2;
memset(target_st, 0, sizeof(struct target_stat64));
target_st->st_dev = tswap16(st.st_dev);
- target_st->st_ino = tswapl(st.st_ino);
+ target_st->st_ino = tswap64(st.st_ino);
#ifdef TARGET_STAT64_HAS_BROKEN_ST_INO
target_st->__st_ino = tswapl(st.st_ino);
#endif
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
reply other threads:[~2003-04-23 8:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030423081611.DF33C2C0A5@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=cyeoh@samba.org \
--cc=fabrice.bellard@free.fr \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).