qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Cc: ehabkost@redhat.com, qemu-devel@nongnu.org, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine
Date: Mon, 4 Jun 2018 14:09:50 -0400	[thread overview]
Message-ID: <2003b551-2bc6-f9fe-8303-837397e4ac01@redhat.com> (raw)
In-Reply-To: <4e58363f-d055-7556-7a71-51f90e461f4e@redhat.com>



On 06/04/2018 08:35 AM, Paolo Bonzini wrote:
> On 04/06/2018 14:24, Igor Mammedov wrote:
>>> Yes it's easy to add -machine pc but there's no documentation
>>> that tells you to do so. Add to that shortcuts like -cdrom
>>> stop working, hotplug needs extra bridges to work, and one
>>> can see that while management tool users benefit from q35,
>>> command line users will suffer.
>> Maybe we should mark 'pc' default as deprecated first,
>> like we do with CLI options that we wish to drop in future?
>>
>> That way we 'create' documentation, so users would be aware
>> of the change and have time to fix their CLI if they prefer
>> 'pc' machine.
> 
> Michael has listed reasons why 'pc' cannot be deprecated, since some of
> them are not even fixable.  Honestly, 'pc' works well for 99% of the use
> cases---just like you probably don't care whether your laptop has a PCI
> or PCIe chipset.
> 
> Paolo
> 
> 

I understood this comment to mean deprecating a *default* machine type.

So if you do `-M pc` you're still OK, but if you simply omit a machine
type and hope for a specific one you're out of luck.

... We could just deprecate having any default and then make QEMU whine
at you if you don't specify one, like we do for guessing format types on
drive images -- it'll do it, but if it guesses raw it whines at you a
little.

  reply	other threads:[~2018-06-04 18:10 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-03  9:27 [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine Marcel Apfelbaum
2018-06-04  1:38 ` Michael S. Tsirkin
2018-06-04 12:24   ` Igor Mammedov
2018-06-04 12:35     ` Paolo Bonzini
2018-06-04 18:09       ` John Snow [this message]
2018-06-04 12:54   ` Eduardo Habkost
2018-06-04 13:01     ` Daniel P. Berrangé
2018-06-04 13:26       ` Eduardo Habkost
2018-06-04 17:17         ` Michael S. Tsirkin
2018-06-04 18:30           ` Eduardo Habkost
2018-06-04 16:48       ` Michael S. Tsirkin
2018-06-04 16:56         ` Daniel P. Berrangé
2018-06-04 18:40           ` Marcel Apfelbaum
2018-06-04 21:08             ` Eduardo Habkost
2018-06-04 18:29   ` Marcel Apfelbaum
2018-06-05  7:27     ` Gerd Hoffmann
2018-06-05  8:43       ` Daniel P. Berrangé
2018-06-05 13:06         ` [Qemu-devel] libvirt default machine-type guarantees? (was Re: [PATCH RFC] hw/pc: set q35 as the default x86 machine) Eduardo Habkost
2018-06-05 13:12           ` Daniel P. Berrangé
2018-06-05 13:35             ` Eduardo Habkost
2018-06-05 13:41               ` Daniel P. Berrangé
2018-06-05 13:44               ` [Qemu-devel] [libvirt] " Pavel Hrdina
2018-06-05 14:03                 ` Eduardo Habkost
2018-06-05 14:07                   ` Daniel P. Berrangé
2018-06-05 14:36                     ` Pavel Hrdina
2018-06-05 14:14                   ` Pavel Hrdina
2018-06-05 16:16             ` [Qemu-devel] " Michael S. Tsirkin
2018-06-05 16:22               ` Daniel P. Berrangé
2018-06-05 13:20         ` [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine Marcel Apfelbaum
2018-06-05 13:29           ` Daniel P. Berrangé
2018-06-05 13:44             ` Laszlo Ersek
2018-06-05 13:51               ` Daniel P. Berrangé
2018-06-05 16:22                 ` Michael S. Tsirkin
2018-06-05 15:56             ` Marcel Apfelbaum
2018-06-05 16:01               ` Daniel P. Berrangé
2018-06-05 16:20             ` Michael S. Tsirkin
2018-06-05 16:23               ` Daniel P. Berrangé
2018-06-05 16:33                 ` Michael S. Tsirkin
2018-06-13 18:05         ` Eduardo Habkost
2018-06-14  8:09           ` Daniel P. Berrangé
2018-06-15  2:50             ` Eduardo Habkost
2018-06-15  9:03               ` Daniel P. Berrangé
2018-06-18 17:14                 ` Eduardo Habkost
2018-06-18 17:18                   ` Michael S. Tsirkin
2018-06-20 17:28                     ` Eduardo Habkost
2018-06-21  7:39                       ` Daniel P. Berrangé
2018-06-20 17:33                     ` Peter Maydell
2018-06-21  7:37                       ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2003b551-2bc6-f9fe-8303-837397e4ac01@redhat.com \
    --to=jsnow@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).