From: Jens Axboe <axboe@suse.de>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] ata bug
Date: Fri, 23 Jan 2004 13:29:10 +0100 [thread overview]
Message-ID: <20040123122910.GA4143@suse.de> (raw)
Hi,
Writing some openbios ide code made me find this bug in qemu - atapi
need only clear busy stat, that is correct, but ata should set seek stat
in addition to ready stat.
Index: ide.c
===================================================================
RCS file: /cvsroot/qemu/qemu/ide.c,v
retrieving revision 1.6
diff -u -r1.6 ide.c
--- ide.c 22 Jan 2004 23:52:27 -0000 1.6
+++ ide.c 23 Jan 2004 12:18:46 -0000
@@ -1284,7 +1284,7 @@
if (s->is_cdrom)
s->status = 0x00; /* NOTE: READY is _not_ set */
else
- s->status = READY_STAT;
+ s->status = READY_STAT | SEEK_STAT;
ide_set_signature(s);
}
}
--
Jens Axboe
reply other threads:[~2004-01-23 12:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040123122910.GA4143@suse.de \
--to=axboe@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).