* [Qemu-devel] [bug] testandset and cpu_interrupt
@ 2004-06-01 22:30 Piotr Krysik
2004-06-02 13:47 ` Richard Zidlicky
0 siblings, 1 reply; 2+ messages in thread
From: Piotr Krysik @ 2004-06-01 22:30 UTC (permalink / raw)
To: qemu-devel
Hello,
Function testandset is referenced by cpu_interrupt,
spin_lock and spin_trylock (spin_lock and spin_trylock
for CONFIG_USER_ONLY). All these invocations assume
that testandset should return zero when lock is
successfully acquired.
I noticed that implementation of testandset for x86
does opposite, i.e. returns NON-zero when lock is
successfully acquired.
Before fixing the problem, it would be useful to check
implementation of testandset for other architectures,
which I'm unable to do.
I'm very impressed with QEMU. Thanks for excellent
work,
Piotrek
__________________________________
Do you Yahoo!?
Friends. Fun. Try the all-new Yahoo! Messenger.
http://messenger.yahoo.com/
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [bug] testandset and cpu_interrupt
2004-06-01 22:30 [Qemu-devel] [bug] testandset and cpu_interrupt Piotr Krysik
@ 2004-06-02 13:47 ` Richard Zidlicky
0 siblings, 0 replies; 2+ messages in thread
From: Richard Zidlicky @ 2004-06-02 13:47 UTC (permalink / raw)
To: qemu-devel
On Tue, Jun 01, 2004 at 03:30:50PM -0700, Piotr Krysik wrote:
> Hello,
>
> Function testandset is referenced by cpu_interrupt,
> spin_lock and spin_trylock (spin_lock and spin_trylock
>
> for CONFIG_USER_ONLY). All these invocations assume
> that testandset should return zero when lock is
> successfully acquired.
>
> I noticed that implementation of testandset for x86
> does opposite, i.e. returns NON-zero when lock is
> successfully acquired.
seems like m68k does the same.
Richard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-06-02 18:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-06-01 22:30 [Qemu-devel] [bug] testandset and cpu_interrupt Piotr Krysik
2004-06-02 13:47 ` Richard Zidlicky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).