From: Tim <tim-qemu@sentinelchicken.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Security house-cleaning
Date: Thu, 17 Jun 2004 21:13:29 -0700 [thread overview]
Message-ID: <20040618041329.GA1920@sentinelchicken.org> (raw)
In-Reply-To: <1087494085.3375.133.camel@sherbert>
> nooooope, strcpy has no way of knowing how big the buffer is other than
> what you tell it. It's likely that all (or most) of the buffers that are
> strcpy'd to are initialised to zero / .bss so it doesn't matter in
> reality, but better safe than sorry. What if some buffer is moved to
> stack later, that would expose the latent bug.
Oh... you are right. It only pads with nulls if the src string is
shorter than the length argument. I'll fix those and submit a new
version in a day or two.
thanks,
tim
prev parent reply other threads:[~2004-06-18 4:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-17 4:38 [Qemu-devel] [PATCH] Security house-cleaning Tim
2004-06-17 15:07 ` Gianni Tedesco
2004-06-17 15:14 ` Renzo Davoli
2004-06-17 15:24 ` Panagiotis Issaris
2004-06-17 15:27 ` Sebastien Bechet
2004-06-17 16:37 ` Tim
2004-06-17 17:03 ` Sander Nagtegaal
2004-06-17 17:16 ` Gianni Tedesco
2004-06-17 19:59 ` Renzo Davoli
2004-06-17 16:05 ` Tim
2004-06-17 17:41 ` Gianni Tedesco
2004-06-18 4:13 ` Tim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040618041329.GA1920@sentinelchicken.org \
--to=tim-qemu@sentinelchicken.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).