From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] linux-user/mmap.c query
Date: Fri, 24 Sep 2004 00:44:47 +0100 [thread overview]
Message-ID: <200409240044.47514.paul@codesourcery.com> (raw)
In-Reply-To: <20040922221648.GD11336@cray.fish.zetnet.co.uk>
On Wednesday 22 September 2004 23:16, cb-qemu@fish.zetnet.co.uk wrote:
> BTW, is it possible to run qemu-arm under gdb and get breakpoints working?
> When I try, gdb complains because the qemu binary is remapped somewhere
> else in the addres space.
Configure with --static.
> --- linux-user/mmap.c 5 Jul 2004 21:25:16 -0000 1.7
> +++ linux-user/mmap.c 22 Sep 2004 20:18:53 -0000
> @@ -182,7 +182,7 @@
> }
> #endif
>
> - if (offset & ~TARGET_PAGE_MASK)
> + if (offset & ~TARGET_PAGE_MASK && 0)
> return -EINVAL;
>
> len = TARGET_PAGE_ALIGN(len);
Isn't this just papering over the problem? What about the other places in that
function which return -EINVAL?
Also the later code handles host misalignment, whereas this test if for target
misalignment.
Paul
prev parent reply other threads:[~2004-09-23 23:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-22 22:16 [Qemu-devel] linux-user/mmap.c query cb-qemu
2004-09-23 23:44 ` Paul Brook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200409240044.47514.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).