From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33)
	id 1CAdN8-0006vH-7d
	for qemu-devel@nongnu.org; Thu, 23 Sep 2004 19:51:34 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33)
	id 1CAdN6-0006v5-Ke
	for qemu-devel@nongnu.org; Thu, 23 Sep 2004 19:51:33 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.33) id 1CAdN6-0006v2-Fu
	for qemu-devel@nongnu.org; Thu, 23 Sep 2004 19:51:32 -0400
Received: from [62.241.160.73] (helo=colossus.systems.pipex.net)
	by monty-python.gnu.org with esmtp (Exim 4.34) id 1CAdGj-0004Ip-Iz
	for qemu-devel@nongnu.org; Thu, 23 Sep 2004 19:44:57 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] linux-user/mmap.c query
Date: Fri, 24 Sep 2004 00:44:47 +0100
References: <20040922221648.GD11336@cray.fish.zetnet.co.uk>
In-Reply-To: <20040922221648.GD11336@cray.fish.zetnet.co.uk>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <200409240044.47514.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Wednesday 22 September 2004 23:16, cb-qemu@fish.zetnet.co.uk wrote:
> BTW, is it possible to run qemu-arm under gdb and get breakpoints working?
> When I try, gdb complains because the qemu binary is remapped somewhere
> else in the addres space.

Configure with --static.

> --- linux-user/mmap.c =A0 5 Jul 2004 21:25:16 -0000 =A0 =A0 =A0 1.7
> +++ linux-user/mmap.c =A0 22 Sep 2004 20:18:53 -0000
> @@ -182,7 +182,7 @@
> =A0 =A0 =A0}
> =A0#endif
> =A0
> - =A0 =A0if (offset & ~TARGET_PAGE_MASK)
> + =A0 =A0if (offset & ~TARGET_PAGE_MASK && 0)
> =A0 =A0 =A0 =A0 =A0return -EINVAL;
> =A0
> =A0 =A0 =A0len =3D TARGET_PAGE_ALIGN(len);

Isn't this just papering over the problem? What about the other places in t=
hat=20
function which return -EINVAL?

Also the later code handles host misalignment, whereas this test if for tar=
get=20
misalignment.

Paul