[Qemu-devel] Audio patch

[Qemu-devel] Audio patch

[Fabrice Bellard]

I commited the version 6 of malc's audio patch. Tell me if you see 
problems. Maybe SDL audio support could be enabled on Mac OS X ?

The version 7 of the patch is not acceptable in its current state as C++ 
is forbidden in QEMU.

Fabrice.

Re: [Qemu-devel] Audio patch

[David E. Still]

I would *love* to have SDL audio support for the Mac.  Perhaps even a 
-sdlaudio switch from the command-line?

Another possibility would be using the liboss library 
(http://liboss.sourceforge.net/), although the project doesn't seem to 
have had much activity of late.  I don't know how viable it is, what it 
would take to implement, or even if it's robust enough for Qemu, but it 
might be worth looking at given the limitations of SDL audio that 
you've mentioned in the past.

- Dave
--
David E. Still
Writer/Producer
TripleCat Productions
http://www.triplecatproductions.com

On Oct 9, 2004, at 10:23 AM, Fabrice Bellard wrote:

> I commited the version 6 of malc's audio patch. Tell me if you see 
> problems. Maybe SDL audio support could be enabled on Mac OS X ?
>
> The version 7 of the patch is not acceptable in its current state as 
> C++ is forbidden in QEMU.
>
> Fabrice.
>
>
>
> _______________________________________________
> Qemu-devel mailing list
> Qemu-devel@nongnu.org
> http://lists.nongnu.org/mailman/listinfo/qemu-devel
>
>

Re: [Qemu-devel] Audio patch

[malc]

On Sat, 9 Oct 2004, Fabrice Bellard wrote:

> I commited the version 6 of malc's audio patch. Tell me if you see
> problems. Maybe SDL audio support could be enabled on Mac OS X ?
>
> The version 7 of the patch is not acceptable in its current state as C++
> is forbidden in QEMU.

For the time being (until C++ magically disapears) 7c_aqemu which should
in apply cleanly to the current CVS is available at:
http://www.boblycat.org/~malc/code/patches/qemu/

-- 
mailto:malc@pulsesoft.com

Re: [Qemu-devel] Audio patch

[John R. Hogerhuis]

On Sat, 2004-10-09 at 18:54, malc wrote:
> For the time being (until C++ magically disapears)

A beautiful dream, my friend.

-- John.

Re: [Qemu-devel] Audio patch

[Johannes Martin]

On Sun, 10 Oct 2004, John R. Hogerhuis wrote:
> On Sat, 2004-10-09 at 18:54, malc wrote:
> > For the time being (until C++ magically disapears)
> A beautiful dream, my friend.
How about somebody uses AT&T's cfront or SUN's GCC2C to convert those
templates in mixeng.cc to plain C? The code won't be pretty, but it will
make more sense than handcoding the stuff.

I guess one could also use some smart macros to replace the templates.

	Johannes

Re: [Qemu-devel] Audio patch

[Fabrice Bellard]

Moreover mixeng.cc uses floats, which are also forbidden in QEMU, except 
for CPU emulation :-)

Fabrice.

Johannes Martin wrote:
> On Sun, 10 Oct 2004, John R. Hogerhuis wrote:
> 
>>On Sat, 2004-10-09 at 18:54, malc wrote:
>>
>>>For the time being (until C++ magically disapears)
>>
>>A beautiful dream, my friend.
> 
> How about somebody uses AT&T's cfront or SUN's GCC2C to convert those
> templates in mixeng.cc to plain C? The code won't be pretty, but it will
> make more sense than handcoding the stuff.
> 
> I guess one could also use some smart macros to replace the templates.
> 
> 	Johannes
> 
> 
> 
> _______________________________________________
> Qemu-devel mailing list
> Qemu-devel@nongnu.org
> http://lists.nongnu.org/mailman/listinfo/qemu-devel
> 
> 

Re: [Qemu-devel] Audio patch

[malc]

On Sun, 10 Oct 2004, Fabrice Bellard wrote:

> Moreover mixeng.cc uses floats, which are also forbidden in QEMU, except
> for CPU emulation :-)

I'm no big C++ fan myself, but credit where it's due, changing these to
int32_t or whatnot is as simple as changing template argument and clamping
code in ONE place - now beat that stupid C99 ;)

>
> Johannes Martin wrote:
> > On Sun, 10 Oct 2004, John R. Hogerhuis wrote:
> >
> >>On Sat, 2004-10-09 at 18:54, malc wrote:
> >>
> >>>For the time being (until C++ magically disapears)
> >>
> >>A beautiful dream, my friend.
> >
> > How about somebody uses AT&T's cfront or SUN's GCC2C to convert those
> > templates in mixeng.cc to plain C? The code won't be pretty, but it will
> > make more sense than handcoding the stuff.
> >
> > I guess one could also use some smart macros to replace the templates.

-- 
mailto:malc@pulsesoft.com

Re: [Qemu-devel] Audio patch

[Johannes Schindelin]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 559 bytes --]

Hi,

On Sun, 10 Oct 2004, malc wrote:

> On Sat, 9 Oct 2004, Fabrice Bellard wrote:
> > The version 7 of the patch is not acceptable in its current state as C++
> > is forbidden in QEMU.
>
> For the time being (until C++ magically disapears) 7c_aqemu which should
> in apply cleanly to the current CVS is available at:
> http://www.boblycat.org/~malc/code/patches/qemu/

Please try the attached patch *after* applying 7c_aqemu. It removes the
need for template Fabrice's Way(TM). I could not test it yet (sitting on a
box without sound card...).

Ciao,
Dscho

[-- Attachment #2: Type: APPLICATION/x-gunzip, Size: 4279 bytes --]

[Qemu-devel] Re: Audio patch

[Ronald]

Le Mon, 11 Oct 2004 16:52:52 +0200, Johannes Schindelin a écrit :

> Hi,
> 
> On Sun, 10 Oct 2004, malc wrote:
> 
>> On Sat, 9 Oct 2004, Fabrice Bellard wrote:
>> > The version 7 of the patch is not acceptable in its current state as
>> > C++ is forbidden in QEMU.
>>
>> For the time being (until C++ magically disapears) 7c_aqemu which should
>> in apply cleanly to the current CVS is available at:
>> http://www.boblycat.org/~malc/code/patches/qemu/
> 
> Please try the attached patch *after* applying 7c_aqemu. It removes the
> need for template Fabrice's Way(TM). I could not test it yet (sitting on a
> box without sound card...).

Doesn't work for me, windows report the device as working but no sound
output. 

Re: [Qemu-devel] Re: Audio patch

[Johannes Schindelin]

Hi,

On Mon, 11 Oct 2004, Ronald wrote:

> Doesn't work for me, windows report the device as working but no sound
> output.

Sorry, still could not test, but one thing is for sure: At the beginning
of mixeng_template.h, the four definitions of HALFT and HALF: could you
change them to

#ifdef SIGNED
#define HALFT (float)(IN_MAX)
#define HALF (float)(IN_MAX)
#else
#define HALFT (float)((IN_MAX)>>1)
#define HALF HALFT
#endif

and test again?

Sorry,
Dscho

[Qemu-devel] Re: Re: Audio patch

[Ronald]

Le Tue, 12 Oct 2004 00:06:50 +0200, Johannes Schindelin a écrit :

> Hi,
> 
> On Mon, 11 Oct 2004, Ronald wrote:
> 
>> Doesn't work for me, windows report the device as working but no sound
>> output.
> 
> Sorry, still could not test, but one thing is for sure: At the beginning
> of mixeng_template.h, the four definitions of HALFT and HALF: could you
> change them to
> 
> #ifdef SIGNED
> #define HALFT (float)(IN_MAX)
> #define HALF (float)(IN_MAX)
> #else
> #define HALFT (float)((IN_MAX)>>1)
> #define HALF HALFT
> #endif
> 
> and test again?
> 

Still the same thing: card reported ok but no output at all.

> Sorry,
> Dscho

Re: [Qemu-devel] Re: Re: Audio patch

[Joe Menola]

On Mon October 11 2004 5:20 pm, Ronald wrote:
> Le Tue, 12 Oct 2004 00:06:50 +0200, Johannes Schindelin a écrit :
> > Hi,
> >
> > On Mon, 11 Oct 2004, Ronald wrote:
> >> Doesn't work for me, windows report the device as working but no sound
> >> output.
> >
> > Sorry, still could not test, but one thing is for sure: At the beginning
> > of mixeng_template.h, the four definitions of HALFT and HALF: could you
> > change them to
> >
> > #ifdef SIGNED
> > #define HALFT (float)(IN_MAX)
> > #define HALF (float)(IN_MAX)
> > #else
> > #define HALFT (float)((IN_MAX)>>1)
> > #define HALF HALFT
> > #endif
> >
> > and test again?
>
> Still the same thing: card reported ok but no output at all.
>
> > Sorry,
> > Dscho

My soundblaster did the same thing.

Malc had a fix for this...

"If you are using Win98 guest make sure that 16bit DMA for SoundBlaster is
set to 5"

HTH-jm