[Qemu-devel] [PATCH] --resend-- Major 254 to Major 250

[Qemu-devel] [PATCH] --resend-- Major 254 to Major 250

[Darryl Dixon]

[-- Attachment #1.1: Type: text/plain, Size: 249 bytes --]

Email formatting mashed the previous patch I sent in, so please find
attached a new copy which works around the 'could not major 254' error
by moving the kqemu device to major 250.

Cheers,
-- 
Darryl Dixon <esrever_otua@pythonhacker.is-a-geek.net>

[-- Attachment #1.2: Type: text/html, Size: 644 bytes --]

[-- Attachment #2: major_250.patch --]
[-- Type: text/x-patch, Size: 707 bytes --]

diff -ru qemu/kqemu/install.sh qemu_major250/kqemu/install.sh
--- qemu/kqemu/install.sh	2005-02-11 11:10:28.000000000 +1300
+++ qemu_major250/kqemu/install.sh	2005-02-12 11:23:14.000000000 +1300
@@ -20,5 +20,5 @@
 # Create the kqemu device. No special priviledge is needed to use kqemu.
 device="/dev/kqemu"
 rm -f $device
-mknod $device c 254 0
+mknod $device c 250 0
 chmod 666 $device
diff -ru qemu/kqemu/kqemu.h qemu_major250/kqemu/kqemu.h
--- qemu/kqemu/kqemu.h	2005-02-11 11:10:28.000000000 +1300
+++ qemu_major250/kqemu/kqemu.h	2005-02-12 11:23:30.000000000 +1300
@@ -1,7 +1,7 @@
 #ifndef KQEMU_H
 #define KQEMU_H
 
-#define KQEMU_MAJOR 254
+#define KQEMU_MAJOR 250
 
 #define KQEMU_VERSION 0x010000

Re: [Qemu-devel] [PATCH] Major 254

[Jim C. Brown]

I am curious why qemu just doesn't set the device number to 0 (which would
allow it to be assigned one by the kernel). Or was that feature removed when
devfs was obsoleted?

-- 
Infinite complexity begets infinite beauty.
Infinite precision begets infinite perfection.

Re: [Qemu-devel] [PATCH] Major 254

[Darryl Dixon]

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]

Good question, I didn't even know that was possible; but if the major
number was auto-assigned, how would the correct device node be created
for it at install time?

D


On Fri, 2005-02-11 at 18:40 -0500, Jim C. Brown wrote:

> I am curious why qemu just doesn't set the device number to 0 (which would
> allow it to be assigned one by the kernel). Or was that feature removed when
> devfs was obsoleted?
> 

-- 
Darryl Dixon <esrever_otua@pythonhacker.is-a-geek.net>

[-- Attachment #2: Type: text/html, Size: 998 bytes --]

Re: [Qemu-devel] [PATCH] Major 254

[Jim C. Brown]

On Sat, Feb 12, 2005 at 01:43:29PM +1300, Darryl Dixon wrote:
> Good question, I didn't even know that was possible; but if the major
> number was auto-assigned, how would the correct device node be created
> for it at install time?
> 
> D
> 
> 

This feature was added when devfs was added - devfs would create the node
(with the right major&minor number) automatically. I assume udev has something
similar.

As a worst case option, the module can simply report which number it got in
dmesg, and then one can create the node by hand.

-- 
Infinite complexity begets infinite beauty.
Infinite precision begets infinite perfection.

Re: [Qemu-devel] [PATCH] Major 254

[Mark Williamson]

> Good question, I didn't even know that was possible; but if the major
> number was auto-assigned, how would the correct device node be created
> for it at install time?

You could do it at load time by reading out of /proc/modules and creating the 
device node to fit.

Cheers,
Mark